Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expands type checking to subtensor #1731

Merged

Conversation

gus-opentensor
Copy link
Collaborator

  • Efficiencies - var is None instead of var == None
  • Object paramater assurances - object.value -> if hasattr(object, "value")
  • Optional types
  • Notes/comments left on implementations where use of method / func was questionable. (see: TODOs)

@ifrit98 ifrit98 self-requested a review March 5, 2024 14:14
Copy link
Contributor

@ifrit98 ifrit98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -748,7 +748,7 @@ def _process_root_weights(

"""
data_array = []
n_subnets = subtensor.get_total_subnets()
n_subnets = subtensor.get_total_subnets() or 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Think this line (or some subtensor change) breaks loading the metagraph. Please check this and try loading the metagraph to test this out

@ifrit98 ifrit98 merged commit 0c05882 into staging Mar 6, 2024
12 checks passed
@ifrit98 ifrit98 mentioned this pull request Mar 7, 2024
@gus-opentensor gus-opentensor deleted the feature/gus/51818215/expand-type-checking-subtensor branch March 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants