Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3 for refactoring bittensor/subtensor.py #1923

Merged
merged 4 commits into from
May 23, 2024

Conversation

RomanCh-OT
Copy link
Contributor

Since the refactoring of this module would turn into a large project, it was decided to divide it into several stages.

This is part 2: current part affects everything up to the subtensor().tempo() method.
The "Hyper parameter calls" section was refactored by DRY.

Part 1 #1911
Part 2 #1913

@RomanCh-OT RomanCh-OT requested a review from a team May 22, 2024 23:08
@RomanCh-OT RomanCh-OT self-assigned this May 22, 2024
@RomanCh-OT RomanCh-OT linked an issue May 22, 2024 that may be closed by this pull request
3 tasks
@RomanCh-OT RomanCh-OT marked this pull request as ready for review May 22, 2024 23:30
… it was decided to divide it into several stages.

This is part 2: current part affects everything up to the subtensor().tempo() method.
The "Hyper parameter calls" section was refactored by DRY.

Part 1 #1911
Part 2 #1913
@RomanCh-OT RomanCh-OT force-pushed the refactoring/roman/subtensor-part-3 branch from 525b717 to 1f36ad1 Compare May 23, 2024 00:27
@RomanCh-OT RomanCh-OT force-pushed the refactoring/roman/subtensor-part-3 branch from a0c3f43 to afa165a Compare May 23, 2024 01:08
@RomanCh-OT RomanCh-OT merged commit 2abd4ec into staging May 23, 2024
11 checks passed
@RomanCh-OT RomanCh-OT deleted the refactoring/roman/subtensor-part-3 branch May 23, 2024 18:13
RomanCh-OT added a commit that referenced this pull request May 23, 2024
… it was decided to divide it into several stages.

This is part 4: current part affects everything up to the subtensor().tx_rate_limit() method.
Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
RomanCh-OT added a commit that referenced this pull request May 24, 2024
… it was decided to divide it into several stages.

This is part 5: current part affects everything in this document except of renaming class `subtensor` according to the CamelCase rule.

Test coverage improved.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
RomanCh-OT added a commit that referenced this pull request May 24, 2024
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
RomanCh-OT added a commit that referenced this pull request May 24, 2024
… it was decided to divide it into several stages.

This is part 6: Renaming class 1 to comply with PEP8 and avoid namespace conflict. Refactor all references to the changed name.

Part 1 #1911
Part 2 #1913
Part 3 #1923
Part 4 #1931
Part 5 #1934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bittensor.subtensor module refactoring
3 participants