Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commit weights and reveal weights functions #1938

Merged
merged 16 commits into from
May 28, 2024

Conversation

opendansor
Copy link
Contributor

Description of the Change

Add a feature to commit weights for specific subnet on the Bittensor network and also to reveal weights for a specific subnet on the Bittensor network.

For Example you can call:
$ btcli wt commit --netuid 1 --uids 1,2,3,4 --weights 0.1,0.2,0.3,0.4
to commit weights, and call
$ btcli wt reveal --netuid 1 --uids 1,2,3,4 --weights 0.1,0.2,0.3,0.4
to reveal the weights on a network.

Verification Process

Add test for coverage, and E2E test with a member of the Nucleus team to make sure compatibility on the calls to the blockchain.

Release Notes

  • Added feature to commit weights for a specific subnet.
  • Added feature to reveal weights for a specific subnet.

@opendansor opendansor changed the base branch from master to staging May 24, 2024 20:59
@opendansor opendansor linked an issue May 24, 2024 that may be closed by this pull request
@opendansor opendansor marked this pull request as ready for review May 24, 2024 23:38
@opendansor opendansor requested a review from a team May 24, 2024 23:38
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of little things. Overall good.

tests/integration_tests/test_subtensor_integration.py Outdated Show resolved Hide resolved
tests/integration_tests/test_subtensor_integration.py Outdated Show resolved Hide resolved
tests/integration_tests/test_subtensor_integration.py Outdated Show resolved Hide resolved
tests/integration_tests/test_subtensor_integration.py Outdated Show resolved Hide resolved
tests/integration_tests/test_subtensor_integration.py Outdated Show resolved Hide resolved
bittensor/extrinsics/commit_weights.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Show resolved Hide resolved
bittensor/subtensor.py Show resolved Hide resolved
tests/e2e_tests/subcommands/weights/test_commit_weights.py Outdated Show resolved Hide resolved
bittensor/utils/weight_utils.py Outdated Show resolved Hide resolved
bittensor/commands/weights.py Show resolved Hide resolved
bittensor/commands/weights.py Outdated Show resolved Hide resolved
bittensor/commands/weights.py Outdated Show resolved Hide resolved
bittensor/extrinsics/commit_weights.py Show resolved Hide resolved
bittensor/extrinsics/commit_weights.py Outdated Show resolved Hide resolved
bittensor/subtensor.py Show resolved Hide resolved
tests/e2e_tests/subcommands/weights/test_commit_weights.py Outdated Show resolved Hide resolved
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small style fix required. Overall looks good!

bittensor/commands/weights.py Outdated Show resolved Hide resolved
bittensor/extrinsics/commit_weights.py Outdated Show resolved Hide resolved
@opendansor opendansor merged commit 9628ca7 into staging May 28, 2024
11 checks passed
ibraheem-opentensor pushed a commit that referenced this pull request May 28, 2024
…ights

Add commit weights and reveal weights functions
@gus-opentensor gus-opentensor mentioned this pull request Jun 1, 2024
@gus-opentensor gus-opentensor mentioned this pull request Jun 4, 2024
gus-opentensor pushed a commit that referenced this pull request Jun 5, 2024
…ights

Add commit weights and reveal weights functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit Reveal Weights
3 participants