Asyc bittensor/extrinsics (part 4)
#2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheem-opentensor
approved these changes
Jun 11, 2024
thewhaleking
requested changes
Jun 11, 2024
| @@ -96,7 +96,7 @@ def set_weights_extrinsic( | |||
| ":satellite: Setting weights on [white]{}[/white] ...".format(subtensor.network) | |||
| ): | |||
| try: | |||
| success, error_message = subtensor._do_set_weights( | |||
| success, error_message = subtensor.do_set_weights( | |||
There was a problem hiding this comment.
Coroutine is never awaited.
There was a problem hiding this comment.
Wait. I almost broke down. But then I realized that this file should not be in this PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclused async migration for:
bittensor/extrinsics/root.pybittensor/extrinsics/senate.py.bittensor/extrinsics/serving.pyAll of them refactored, has some small bug fixes, and async migrated.
For easy review you can do this via commits.