[BIT-525] Tokenizer improvements (whitespace-preserving) #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepends strings with a space, in the case of non whitespace-preserving tokenizers like BERT, which should mimic whitespace-preserving token strings more often than not. Adds error catching on per-UID basis in shapley_base for synapse validation to be more robust.
Pull Request Test Coverage Report for Build 2e371905-94af-4e6c-b746-2528dc9f4f3b
💛 - Coveralls |
Eugene-hu
approved these changes
Jul 27, 2022
| @@ -18,7 +18,9 @@ | |||
| # DEALINGS IN THE SOFTWARE. | |||
|
|
|||
| from transformers import AutoTokenizer | |||
| import bittensor | |||
| import bittensor | |||
| from bittensor.utils.tokenizer_utils import prep_tokenizer | |||
There was a problem hiding this comment.
Would we expect users to use the prep_tokenizer function a lot? If so, it might be good to have it as a class function as well
There was a problem hiding this comment.
Not really, it's just to prepare the server tokenizer (and the bittensor.tokenizer gets prepared automatically). So clients wouldn't need to run it, for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT-525 Tokenizer improvements (whitespace-preserving)
Add support for non whitespace-preserving tokenizers.
Prepends strings with a space, in the case of non whitespace-preserving tokenizers like BERT, which should mimic whitespace-preserving token strings more often than not.
Adds error catching on per-UID basis in shapley_base for synapse validation to be more robust.