Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix] fix flags for run command, fix hotkeys flag for overview, and [feature] CUDA reg #877

Merged
merged 7 commits into from
Aug 16, 2022
Merged

[hotfix] fix flags for run command, fix hotkeys flag for overview, and [feature] CUDA reg #877

merged 7 commits into from
Aug 16, 2022

Conversation

camfairchild
Copy link
Collaborator

@camfairchild camfairchild commented Aug 12, 2022 •
edited

#876 Fixes the flags

The CPU register optimization introduced a bug where the btcli run command lacked some config flags that were used in CLI.register.
This PR adds them in

Edit:

This PR also adds
#868 and #867

camfairchild and others added 3 commits August 11, 2022 14:56
@camfairchild
[feature] cpu register faster (#854)
4288c3a 
* add update interval and num proc flag

* add better number output

* optimize multiproc cpu reg
keeping proc until solution

* fix test

* make sure to exit properly if registered during

* fix tests

* change import to use tests

* add optional type hints and None default

* change to count using allowed processes

* add documentation. Fix random start
@camfairchild
[hotfix] fix flags for multiproc register limit (#876)
4629b82 
* add dot get

* add to subtensor args and defaults

* remove dot get because in subtensor args

* typo

* fix test
@Eugene-hu
Merge remote-tracking branch 'origin/master' into nobunaga
3ade241
@camfairchild
Copy link
Collaborator Author

I can't make the merge myself. master has to be merged back into nobunaga first

@camfairchild camfairchild reopened this Aug 12, 2022
@camfairchild
Copy link
Collaborator Author

Wait for merge of #878

@camfairchild
Fix/diff unpack bit shift (#878)
224719c 
* fix incorrect bit shift

* move inner function out and add test for diff pack

* fix test

* fix call arg check in test

* add assert

* fix test for py37

* refactor the diff pack into two functions
move the test to a unit test

* fix test
@camfairchild
Copy link
Collaborator Author

camfairchild commented Aug 15, 2022 •
edited

Wait for #868 to merge in

@camfairchild
[Feature] [cubit] CUDA registration solver (#868)
c546d3f 
* added cuda solver

* boost versions to fix pip error

* allow choosing device id

* fix solution check to use keccak

* adds params for cuda and dev_id to register

* list devices by name during selection

* add block number logging

* fix calculation of hashrate

* fix update interval default

* add --TPB arg to register

* add update_interval flag

* switch back to old looping/work structure

* change typing

* device count is a function

* stop early if wallet registered

* add update interval and num proc flag

* add better number output

* optimize multiproc cpu reg
keeping proc until solution

* fix test

* change import to cubit

* fix import and default

* up default
should have default in CLI call

* add comments about params

* fix config var access

* add cubit as extra

* handle stale pow differently
check registration after failure

* restrict number of processes for integration test

* fix stale check

* use wallet.is_registered instead

* attempt to fix test issue

* fix my test

* oops typo

* typo again ugh

* remove print out

* fix partly reg test

* fix if solution None

* fix test?

* fix patch

* add args for cuda to subtensor

* add cuda args to reregister call

* add to wallet register the cuda args

* fix refs and tests

* add for val test also

* fix tests with rereg

* fix patch for tests

* add mock_register to subtensor passed instead

* move register under the check for isregistered

* use patch obj instead

* fit patch object
@camfairchild camfairchild changed the title [hotfix] fix flags for run command [hotfix] fix flags for run command and [feature] CUDA reg Aug 15, 2022
@camfairchild camfairchild changed the title [hotfix] fix flags for run command and [feature] CUDA reg [hotfix] fix flags for run command, fix overview with hotkeys flag, and [feature] CUDA reg Aug 15, 2022
@camfairchild camfairchild changed the title [hotfix] fix flags for run command, fix overview with hotkeys flag, and [feature] CUDA reg [hotfix] fix flags for run command and [feature] CUDA reg Aug 15, 2022
@camfairchild camfairchild changed the title [hotfix] fix flags for run command and [feature] CUDA reg [hotfix] fix flags for run command, fix hotkeys flag for overview, and [feature] CUDA reg Aug 15, 2022
@camfairchild
Fix/move overview args to cli (#867)
fb6be7c 
* move cli args to CLI and fix overview

* use dot get

* fix tests

* add hotkeys/all_hotkeys to (un)stake

* fix default

* fix default in unstake

* add unstake multiple

* add add stake multiple

* move all/hotkeys back to wallet args

* convert to balance first
add catch for unstake multi

* fix ref to wallet

* fix test patch for multi hotkeys

* try to fix tests

* fix tests patch

* fix mock wallet length

* don't use new?

* fix call args get

* typo

* fix typo
isabella618033
isabella618033 reviewed Aug 15, 2022
View reviewed changes
bittensor/_cli/__init__.py Outdated Show resolved Hide resolved
bittensor/_cli/__init__.py Outdated Show resolved Hide resolved
bittensor/_cli/__init__.py Show resolved Hide resolved
bittensor/_subtensor/subtensor_impl.py Outdated Show resolved Hide resolved
bittensor/_subtensor/subtensor_impl.py Show resolved Hide resolved
bittensor/_subtensor/subtensor_impl.py Outdated Show resolved Hide resolved
bittensor/_subtensor/subtensor_impl.py Show resolved Hide resolved
bittensor/_subtensor/subtensor_impl.py Show resolved Hide resolved
bittensor/utils/__init__.py Show resolved Hide resolved
bittensor/utils/__init__.py Outdated Show resolved Hide resolved
@camfairchild camfairchild mentioned this pull request Aug 15, 2022
Merged
@camfairchild
Add/address CUDA reg changes (#879)
b9ca298 
* added cuda solver

* boost versions to fix pip error

* allow choosing device id

* fix solution check to use keccak

* adds params for cuda and dev_id to register

* list devices by name during selection

* add block number logging

* fix calculation of hashrate

* fix update interval default

* add --TPB arg to register

* add update_interval flag

* switch back to old looping/work structure

* change typing

* device count is a function

* stop early if wallet registered

* add update interval and num proc flag

* add better number output

* optimize multiproc cpu reg
keeping proc until solution

* fix test

* change import to cubit

* fix import and default

* up default
should have default in CLI call

* add comments about params

* fix config var access

* add cubit as extra

* handle stale pow differently
check registration after failure

* restrict number of processes for integration test

* fix stale check

* use wallet.is_registered instead

* attempt to fix test issue

* fix my test

* oops typo

* typo again ugh

* remove print out

* fix partly reg test

* fix if solution None

* fix test?

* fix patch

* add args for cuda to subtensor

* add cuda args to reregister call

* add to wallet register the cuda args

* fix refs and tests

* add for val test also

* fix tests with rereg

* fix patch for tests

* add mock_register to subtensor passed instead

* move register under the check for isregistered

* use patch obj instead

* fit patch object

* fix prompt

* remove unneeded if

* modify POW submit to use rolling submit again

* add backoff to block get from network

* add test for backoff get block

* suppress the dev id flag if not set

* remove dest so it uses first arg

* fix pow submit loop

* move registration status with

* fix max attempts check

* remove status in subtensor.register

* add submit status

* change to neuron get instead

* fix count

* try to patch live display

* fix patch

* .

* separate test cases

* add POWNotStale and tests

* add more test cases for block get with retry

* fix return to None

* fix arg order
@camfairchild camfairchild merged commit b54523e into master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shibshib shibshib shibshib approved these changes

@isabella618033 isabella618033 isabella618033 approved these changes

@opentaco opentaco Awaiting requested review from opentaco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camfairchild @shibshib @isabella618033 @Eugene-hu