Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bit 553 bug fixes #886

Merged
merged 28 commits into from
Sep 1, 2022
Merged

Bit 553 bug fixes #886

merged 28 commits into from
Sep 1, 2022

Conversation

isabella618033
Copy link
Contributor

  • axon priority_threadpool not passed through
  • remove server's error message on validator side
  • server set weight block time to be independent with optimisation step
  • axon wasnt timing out at 12 sec
  • responsive uid not counted properly

Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few comments that we need to be careful about

bittensor/_threadpool/priority_thread_pool_impl.py Outdated Show resolved Hide resolved
bittensor/_threadpool/priority_thread_pool_impl.py Outdated Show resolved Hide resolved
bittensor/_axon/axon_impl.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isabella618033 isabella618033 merged commit e5198d0 into nobunaga Sep 1, 2022
@Eugene-hu Eugene-hu mentioned this pull request Sep 2, 2022
@ifrit98 ifrit98 deleted the BIT-553-timeout_bug_fix branch May 24, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants