Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add print module #19

Merged
merged 10 commits into from
Jun 29, 2018
Merged

Add print module #19

merged 10 commits into from
Jun 29, 2018

Conversation

zhe-db
Copy link
Contributor

@zhe-db zhe-db commented Jun 27, 2018

Add AWPrint for desktop

@zhe-db zhe-db self-assigned this Jun 27, 2018
jasonaibrahim
jasonaibrahim suggested changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@jasonaibrahim jasonaibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good for the most part, but it just looks like comments were stripped out? can you add those back in please.

@zhe-db
Copy link
Contributor Author

zhe-db commented Jun 29, 2018

Oh, didnt notice that, since I run ts:export, must be tsc overwrote those typing header file, anyway, already reversed them manually. Thanks.

@jasonaibrahim jasonaibrahim merged commit ba1360b into master Jun 29, 2018
@jasonaibrahim jasonaibrahim deleted the develop-kevin branch September 5, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonaibrahim jasonaibrahim jasonaibrahim approved these changes

Assignees

@zhe-db zhe-db

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhe-db @jasonaibrahim