[coap] resolve the issue where pending requests cannot be matched with their corresponding response messages with UDP port #10269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
their corresponding response messages In function FindRelatedRequest, parameter aMessageInfo represents the message received from the peer device. When iterating through pending requests, the outgoing message's destination address and port should match the source address and port of the received message instead of the destination address and port of the received message.
Size Report of OpenThread
|
abtink
reviewed
May 18, 2024
| aMetadata.mDestinationAddress.IsMulticast() || | ||
| aMetadata.mDestinationAddress.GetIid().IsAnycastLocator()) && | ||
| (aMetadata.mDestinationPort == aMessageInfo.GetPeerPort())) | ||
| (aMetadata.mDestinationPort == aMessageInfo.GetSockPort())) |
There was a problem hiding this comment.
I think the existing code is correct. It leverages MessageInfo, which is applicable to both transmitting (tx) and receiving (rx) messages, dynamically adjusting the interpretation of "peer" and "local".
Within a MessageInfo the peer address/port consistently refers to the other device involved in the communication (either the source we received the message from or the destination we are sending it to).
Specifically:
- For a received message,
GetPeerAddress()will be the source address (sender's address). - For a sent message,
GetPeerAddress()will be the destination address.
There was a problem hiding this comment.
@ZhangLe2016 I noticed you've changed the PR to only use GetSockPort(). However, the earlier comment applies to GetPeerPort() same was as GetPeerAddress(). The existing code using the peer's port and address is the correct behavior.
Considering this, suggest closing this PR?
ZhangLe2016
changed the title
their corresponding response messages with UDP port In function FindRelatedRequest, parameter aMessageInfo represents the message received from the peer device. When iterating through pending requests, the outgoing message's destination port should match the destination port of the received message such as :MM 61631.
|
@abtink Thanks a lot for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function
FindRelatedRequest, parameteraMessageInforepresents the message received from the peer device. When iterating through pending requests, the outgoing message's destination address and port should match the source address and port of the received message instead of the destination address and port of the received message.