Do not revert to non-volatile settings when changed by application. #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwhui
force-pushed
the
pr/network-param-config
branch
from
5455129
to
0455c96
Compare
nibanks
suggested changes
Apr 12, 2017
| OTCALL | ||
| otThreadSetExtendedPanId( | ||
| _In_ otInstance *aInstance, | ||
| const uint8_t *aExtendedPanId | ||
| ) | ||
| { | ||
| if (aInstance) (void)SetIOCTL(aInstance, IOCTL_OTLWF_OT_EXTENDED_PANID, (const otExtendedPanId*)aExtendedPanId); | ||
| if (aInstance == nullptr) return kThreadError_InvalidArgs; | ||
| return DwordToThreadError(SetIOCTL(aInstance, IOCTL_OTLWF_OT_EXTENDED_PANID, (const otExtendedPanId*)aExtendedPanId)); |
There was a problem hiding this comment.
You need to also update iocontrol.c to pass the error from OpenThread back; similar to this.
There was a problem hiding this comment.
Thanks for pointing that out. Updated!
jwhui
force-pushed
the
pr/network-param-config
branch
from
0455c96
to
3b10490
Compare
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 71.34% 69.75% -1.59%
==========================================
Files 154 159 +5
Lines 18465 20266 +1801
Branches 2259 2481 +222
==========================================
+ Hits 13173 14137 +964
- Misses 4475 5223 +748
- Partials 817 906 +89
Continue to review full report at Codecov.
|
jwhui
force-pushed
the
pr/network-param-config
branch
from
3b10490
to
2c6a243
Compare
nibanks
approved these changes
Apr 13, 2017
- Invalidate Active and Pending Datasets when configs are changed via APIs. - Do not allow client to change network configurations while Thread is enabled.
jwhui
force-pushed
the
pr/network-param-config
branch
from
2c6a243
to
6e8ccf1
Compare
vaas-krish
pushed a commit
to vaas-krish/openthread
that referenced
this pull request
May 23, 2017
…s/github_2017_04_18_8f10a4 to master * commit '1ca70d8da5672ee9179ced326ebced6109377971': prevent from subscribing multicast address twice (openthread#1609) print error message on cli failure (openthread#1610) Coap fixes (openthread#1606) Fix compiler warning and code style. (openthread#1605) Restrict 15.4 Beacon transmissions to REEDs/Routers/Leaders. (openthread#1591) Remove `extern "C"` from cpp files. (openthread#1595) Not include non requested TLV in Child Update Response from parent (openthread#1604) THCI: enhancements (openthread#1603) `Logging`: Fix the typo in `otLogCrit()` macro argument `aInstance` (openthread#1598) Update `otPlatRadioReceiveDone()` description to add `kThreadError_NoBufs` error. (openthread#1597) `LinkQualityInfo`: Ensure not to add an invalid/unknown RSS to average. (openthread#1594) Revised README / Landing page (openthread#1585) `spinel.h`: Adjust spacing and alignments (again...) (openthread#1587) Do not revert to non-volatile settings when changed by application. (openthread#1586) Refine API for creating CoAP message (openthread#1584) Parent keeps restoring children until success or timeout (openthread#1581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1524.