[autoconf] remove bashisms from configure.ac #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `configure` script runs with `#!/bin/sh`, but actually required bash. POSIX sh does not have either the `function` keyword or pattern replacement in variable subsititutions.
Size Report of OpenThread
|
Codecov Report
@@ Coverage Diff @@
## master #5658 +/- ##
==========================================
- Coverage 78.05% 77.80% -0.26%
==========================================
Files 377 377
Lines 48115 48074 -41
==========================================
- Hits 37558 37403 -155
- Misses 10557 10671 +114
|
jwhui
changed the title
jwhui
approved these changes
Oct 16, 2020
simonlingoogle
pushed a commit
to simonlingoogle/openthread
that referenced
this pull request
Nov 12, 2020
Bug: 171270296 * origin/github/master: [notifier] simplify 'EventToString()' (openthread#5657) [notifier] signal change to active or pending Operational Dataset (openthread#5657) [coap] add helper method 'Message::SetTokenFromMessage()' (openthread#5661) [dataset-manager] misc enhancements (openthread#5655) [simulation] add configuration MAX_NETWORK_SIZE (openthread#5565) [lib-url] update 'Makefile' to include 'src/core' in header path search (openthread#5659) [code-utils] enhance 'VerifyOrExit' to make action optional (openthread#5659) [autoconf] remove bashisms from configure.ac (openthread#5658) [otns] emit COAP send/receive events to OTNS (openthread#5656) [logging] update logging to use new helper macros (openthread#5650) [common] macros to get first/second/rest of variadic arguments (openthread#5650) [continuous-integration] kill ot-rcp and ot-cli in pty check (openthread#5654) [cli] add context for the user commands (openthread#5587) [thread-cert] turn off OTBR NAT64 in 1.2 Backbone tests (openthread#5652) [low-power] add an Enh-ACK frame link layer counter (openthread#5583) [thread-cert] refactor case 9.2.12 and 9.2.13 using pktverify (openthread#5442) [coap] allow max URI path length (openthread#5645) [harness-automation] update readme (openthread#5646) [common] use non-copyable for more instance-unique classes (openthread#5639) [linux] fix missing correct mtu (openthread#5642) [docs] update Doxygen menu (openthread#5641) [thread-cert] enhance case 5.6.7 for data version increment (openthread#5643) [cc1352,cc2652] add check before claiming transmit done (openthread#5640) [cli] add command to set/get external FEM's LNA gain (openthread#5563) [ip6] no anycast as source address (openthread#5632) [debug] prefer user provided assert to system assert (openthread#5624) Change-Id: Ia7e971ebfef8a78dda9e818698e46831b41d1ec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configurescript runs with#!/bin/sh, but actually requiredbash. POSIX sh does not have either the
functionkeyword or patternreplacement in variable subsititutions.