New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spinel-interface] add config option to change the rx frame buffer size #5687
[spinel-interface] add config option to change the rx frame buffer size #5687
Conversation
Size Report of OpenThread
|
Codecov Report
@@ Coverage Diff @@
## master #5687 +/- ##
==========================================
- Coverage 84.83% 78.71% -6.12%
==========================================
Files 374 378 +4
Lines 46428 48233 +1805
==========================================
- Hits 39385 37968 -1417
- Misses 7043 10265 +3222
|
Adds `OPENTHREAD_CONFIG_PLATFORM_RADIO_SPINEL_RX_FRAME_BUFFER_SIZE` config option which specifies the rx frame buffer size used by `SpinelInterface` in RCP host (posix) code. This is applicable/used when `RadioSpinel` platform is used.
60c67bc
to
7ec200f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Agree that we should increase the buffer size.
Furthermore, should we increase the default baudrate to 460800 on RCP devices? Baudrate 115200 is simply not fast enough for transmitting 802.15.4 packets.
Yes, we should increase the default baud rate. |
Bug: 171667863 * origin/github/master: [efr32] remove sTxPowerDbm and use RAIL_GetTxPowerDbm() (openthread#5701) [cmdline-parser] avoid casting -INT32_MIN directly to int32_t (openthread#5702) [efr32] use OT_PLAT_RESET_REASON_OTHER for brown-out/EM4 reset (openthread#5699) [efr32] disable OT software CSMA backoff and energy scan (openthread#5700) [posix] fix MLE sends ICMPv6 destination unreachable (openthread#5585) [api] check on prefix length when slaac is enabled (openthread#5530) [efr32] avoid asserts during data requests (openthread#5697) [posix] ignore unexpected host netif state notification (openthread#5691) [style] clang-tidy misc enhancements (openthread#5695) [backbone-router] backbone TMF enhancements (openthread#5660) [cmake] add external platform support (openthread#5693) [spinel] use OT version rather than MAC config in radio spinel (openthread#5683) [spinel-interface] add config option to change the rx frame buffer size (openthread#5687) [cc2538] add energy scan (openthread#5681) [clang-tidy] apply readability-make-member-function-const (openthread#5675) [script] add clang-tidy check and fix (openthread#5675) [nrf528xx] fix typo of return value in otPlatSpiSlavePrepareTransaction (openthread#5682) [cli] add energy scan channel (openthread#5677) [logging] update OT logging (use functions) (openthread#5674) [notifier] define 'kEventStrings[]' as const pointer (openthread#5673) [efr32] common platform abstraction layer (openthread#5666) [border-agent] misc enhancements (openthread#5663) [cmake-build] ensure cc2538 uses 'CMAKE_BUILD_TYPE=Release' (openthread#5669) [bootstrap] use sudo when creating arm symlinks (openthread#5668) Change-Id: I683911c5b655a132c8d940aa5e67c01bca41c313
Adds
OPENTHREAD_CONFIG_PLATFORM_RADIO_SPINEL_RX_FRAME_BUFFER_SIZE
config option which specifies the rx frame buffer size used by
SpinelInterface
in RCP host (posix) code. This is applicable/used whenRadioSpinel
platform is used.This is related to #5678.