Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spinel-interface] add config option to change the rx frame buffer size #5687

Merged

Conversation

abtink
Copy link
Member

@abtink abtink commented Oct 22, 2020

Adds OPENTHREAD_CONFIG_PLATFORM_RADIO_SPINEL_RX_FRAME_BUFFER_SIZE
config option which specifies the rx frame buffer size used by
SpinelInterface in RCP host (posix) code. This is applicable/used when
RadioSpinel platform is used.


This is related to #5678.

src/core/config/platform.h Outdated Show resolved Hide resolved
@size-report
Copy link

size-report bot commented Oct 22, 2020

Size Report of OpenThread

Merging #5687 into master(a04b6ea).

name branch text data bss total
ot-cli-ftd_1.1 master 384060 736 72700 457496
#5687 384060 736 72700 457496
+/- 0 0 0 0
ot-cli-mtd_1.1 master 311548 736 64116 376400
#5687 311548 736 64116 376400
+/- 0 0 0 0
ot-ncp-ftd_1.1 master 378012 736 71980 450728
#5687 378012 736 71980 450728
+/- 0 0 0 0
ot-ncp-mtd_1.1 master 308476 736 63396 372608
#5687 308476 736 63396 372608
+/- 0 0 0 0
ot-rcp_1.1 master 64296 636 7512 72444
#5687 64296 636 7512 72444
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 master 38248 0 3108 41356
#5687 38248 0 3108 41356
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.1 master 31067 0 3108 34175
#5687 31067 0 3108 34175
+/- 0 0 0 0
libopenthread-ftd.a_1.1 master 189863 4 54992 244859
#5687 189863 4 54992 244859
+/- 0 0 0 0
libopenthread-mtd.a_1.1 master 129879 4 46408 176291
#5687 129879 4 46408 176291
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 master 48147 0 2388 50535
#5687 48147 0 2388 50535
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.1 master 43343 0 2388 45731
#5687 43343 0 2388 45731
+/- 0 0 0 0
libopenthread-rcp.a_1.1 master 27198 0 1532 28730
#5687 27198 0 1532 28730
+/- 0 0 0 0
libopenthread-radio.a_1.1 master 13388 0 150 13538
#5687 13388 0 150 13538
+/- 0 0 0 0
ot-cli-ftd_1.2 master 404676 736 81668 487080
#5687 404676 736 81668 487080
+/- 0 0 0 0
ot-cli-mtd_1.2 master 320228 736 64332 385296
#5687 320228 736 64332 385296
+/- 0 0 0 0
ot-ncp-ftd_1.2 master 396420 736 80948 478104
#5687 396420 736 80948 478104
+/- 0 0 0 0
ot-ncp-mtd_1.2 master 316308 736 63612 380656
#5687 316308 736 63612 380656
+/- 0 0 0 0
ot-rcp_1.2 master 69280 636 16316 86232
#5687 69280 636 16316 86232
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 master 39576 0 3108 42684
#5687 39576 0 3108 42684
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.2 master 31511 0 3108 34619
#5687 31511 0 3108 34619
+/- 0 0 0 0
libopenthread-ftd.a_1.2 master 208963 4 63904 272871
#5687 208963 4 63904 272871
+/- 0 0 0 0
libopenthread-mtd.a_1.2 master 137764 4 46568 184336
#5687 137764 4 46568 184336
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 master 48147 0 2388 50535
#5687 48147 0 2388 50535
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.2 master 43343 0 2388 45731
#5687 43343 0 2388 45731
+/- 0 0 0 0
libopenthread-rcp.a_1.2 master 27198 0 1532 28730
#5687 27198 0 1532 28730
+/- 0 0 0 0
libopenthread-radio.a_1.2 master 14084 0 150 14234
#5687 14084 0 150 14234
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #5687 into master will decrease coverage by 6.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5687      +/-   ##
==========================================
- Coverage   84.83%   78.71%   -6.12%     
==========================================
  Files         374      378       +4     
  Lines       46428    48233    +1805     
==========================================
- Hits        39385    37968    -1417     
- Misses       7043    10265    +3222     
Impacted Files Coverage Δ
src/core/api/dns_api.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/net/dns_headers.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/utils/jam_detector.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/utils/slaac_address.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/net/sntp_client.hpp 0.00% <0.00%> (-80.00%) ⬇️
src/core/net/dns_client.cpp 6.63% <0.00%> (-67.30%) ⬇️
src/core/api/jam_detection_api.cpp 0.00% <0.00%> (-52.95%) ⬇️
src/core/api/sntp_api.cpp 0.00% <0.00%> (-50.00%) ⬇️
src/core/net/dns_client.hpp 50.00% <0.00%> (-50.00%) ⬇️
src/core/thread/discover_scanner.hpp 50.00% <0.00%> (-50.00%) ⬇️
... and 110 more

Adds `OPENTHREAD_CONFIG_PLATFORM_RADIO_SPINEL_RX_FRAME_BUFFER_SIZE`
config option which specifies the rx frame buffer size used by
`SpinelInterface` in RCP host (posix) code. This is applicable/used when
`RadioSpinel` platform is used.
@abtink abtink force-pushed the spinel-interface/add-config-for-rx-buffer-size branch from 60c67bc to 7ec200f Compare October 22, 2020 21:45
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Agree that we should increase the buffer size.

Furthermore, should we increase the default baudrate to 460800 on RCP devices? Baudrate 115200 is simply not fast enough for transmitting 802.15.4 packets.

@jwhui
Copy link
Member

jwhui commented Oct 23, 2020

Furthermore, should we increase the default baudrate to 460800 on RCP devices? Baudrate 115200 is simply not fast enough for transmitting 802.15.4 packets.

Yes, we should increase the default baud rate.

@jwhui jwhui merged commit 50f9881 into openthread:master Oct 23, 2020
@jwhui jwhui linked an issue Nov 4, 2020 that may be closed by this pull request
simonlingoogle pushed a commit to simonlingoogle/openthread that referenced this pull request Nov 12, 2020
Bug: 171667863

* origin/github/master:
  [efr32] remove sTxPowerDbm and use RAIL_GetTxPowerDbm() (openthread#5701)
  [cmdline-parser] avoid casting -INT32_MIN directly to int32_t (openthread#5702)
  [efr32] use OT_PLAT_RESET_REASON_OTHER for brown-out/EM4 reset (openthread#5699)
  [efr32] disable OT software CSMA backoff and energy scan (openthread#5700)
  [posix] fix MLE sends ICMPv6 destination unreachable (openthread#5585)
  [api] check on prefix length when slaac is enabled (openthread#5530)
  [efr32] avoid asserts during data requests (openthread#5697)
  [posix] ignore unexpected host netif state notification (openthread#5691)
  [style] clang-tidy misc enhancements (openthread#5695)
  [backbone-router] backbone TMF enhancements (openthread#5660)
  [cmake] add external platform support (openthread#5693)
  [spinel] use OT version rather than MAC config in radio spinel (openthread#5683)
  [spinel-interface] add config option to change the rx frame buffer size (openthread#5687)
  [cc2538] add energy scan (openthread#5681)
  [clang-tidy] apply readability-make-member-function-const (openthread#5675)
  [script] add clang-tidy check and fix (openthread#5675)
  [nrf528xx] fix typo of return value in otPlatSpiSlavePrepareTransaction (openthread#5682)
  [cli] add energy scan channel (openthread#5677)
  [logging] update OT logging (use functions) (openthread#5674)
  [notifier] define 'kEventStrings[]' as const pointer (openthread#5673)
  [efr32] common platform abstraction layer (openthread#5666)
  [border-agent] misc enhancements (openthread#5663)
  [cmake-build] ensure cc2538 uses 'CMAKE_BUILD_TYPE=Release' (openthread#5669)
  [bootstrap] use sudo when creating arm symlinks (openthread#5668)
Change-Id: I683911c5b655a132c8d940aa5e67c01bca41c313
@abtink abtink deleted the spinel-interface/add-config-for-rx-buffer-size branch February 23, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Daemon] Error decoding hdcl frame: nobuffs
4 participants