[mdns] fix bug that avahi may publish redundant meshcop services #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1104 +/- ##
=======================================
Coverage 56.76% 56.77%
=======================================
Files 85 85
Lines 6352 6358 +6
=======================================
+ Hits 3606 3610 +4
- Misses 2746 2748 +2
Continue to review full report at Codecov.
|
superwhd
force-pushed
the
avahi-rename-keep-track
branch
from
c1b8a33
to
bcfd52c
Compare
wgtdkp
approved these changes
Nov 22, 2021
Damian-Nordic
approved these changes
Nov 22, 2021
jwhui
changed the title
Irving-cl
pushed a commit
to Irving-cl/ot-br-posix
that referenced
this pull request
Dec 7, 2021
…nthread#1104) Avahi may rename the meshcop service and publish it when there's a name conflict. However, our current logic has a bug that it may publish redundant meshcop services after some renaming. For example there are two BRs on the infra link: - BR1 starts. It publishes instance._meshcop._udp. - BR2 starts. It publishes instance openthread#1._meshcop._udp. - BR1 stops. It unpublishes instance._meshcop._udp. - BR2 wants to update the existing meshcop service. However, it actually publishes a new service instance._meshcop._udp. There are two meshcop services existing at the same time both published by BR2. To fix this bug, we will keep track of the original name in the avahi publisher. When we call PublishService, we should always pass in the original name and let the publisher handle the renaming. In this way we will be able to find the wanted service when updating it or unpublishing it. GitOrigin-RevId: d14c225 (cherry picked from commit 33eb9b87edade197db47f857836ef1642d74ee33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avahi may rename the meshcop service and publish it when there's a name conflict. However, our current logic has a bug that it may publish redundant meshcop services after some renaming.
For example there are two BRs on the infra link:
instance._meshcop._udp.instance #1._meshcop._udp.instance._meshcop._udp.instance._meshcop._udp. There are two meshcop services existing at the same time both published by BR2.To fix this bug, we will keep track of the original name in the avahi publisher. When we call
PublishService, we should always pass in the original name and let the publisher handle the renaming. In this way we will be able to find the wanted service when updating it or unpublishing it.The test case is covered in openthread/openthread#7192.