Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] bump to latest Simple-Web-Server version #1667

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

agners
Copy link
Contributor

@agners agners commented Dec 20, 2022

Bump Simple-Web-Server to the latest git commit. This also fixes a compile issue seen with GCC 12.2.0:

In file included from /home/sag/projects/openthread/ot-br-posix/src/web/web-service/web_server.cpp:42: /home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp: In instantiation of ‘SimpleWeb::ServerBase<socket_type>::Request::Request(const socket_type&) [with socket_type = boost::asio::basic_stream_socket<boost::asio::ip::tcp>]’:
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:460:74:   required from here
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:119:57: error: member ‘SimpleWeb::ServerBase<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >::Request::streambuf’ is used uninitialized [-Werror=uninitialized]
  119 |             Request(const socket_type &socket): content(streambuf) {
      |                                                         ^~~~~~~~~

Bump Simple-Web-Server to the latest git commit. This fixes a compile
issue seen with GCC 12.2.0:

In file included from /home/sag/projects/openthread/ot-br-posix/src/web/web-service/web_server.cpp:42: /home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp: In instantiation of ‘SimpleWeb::ServerBase<socket_type>::Request::Request(const socket_type&) [with socket_type = boost::asio::basic_stream_socket<boost::asio::ip::tcp>]’:
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:460:74:   required from here
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:119:57: error: member ‘SimpleWeb::ServerBase<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >::Request::streambuf’ is used uninitialized [-Werror=uninitialized]
  119 |             Request(const socket_type &socket): content(streambuf) {
      |                                                         ^~~~~~~~~
@wgtdkp
Copy link
Member

wgtdkp commented Dec 20, 2022

@agners FYI, in case you want a production-class web server, #537 is a PR which replaces the Simple-Web-Server with Nginx and provides complete RESTful API set which is comparable with d-bus. I am appreciated if you are interested in moving that PR forward :)

@agners
Copy link
Contributor Author

agners commented Dec 20, 2022

@wgtdkp hm, interesting PR, wasn't aware of that effort thanks for linking. I am not particularly interested in the web interface, I use it more as a development/debugging tool right now. In the end we will disable it most likely. However, the changes to the REST seems to be interesting. The PR seems to do quite a bit for a single PR, maybe splitting out the REST changes would be a first step?

@wgtdkp
Copy link
Member

wgtdkp commented Dec 21, 2022

The PR seems to do quite a bit for a single PR, maybe splitting out the REST changes would be a first step?

@agners Agree, it sounds to be reasonable and easier to forward!

@jwhui
Copy link
Member

jwhui commented Dec 22, 2022

@agners @wgtdkp , I'm supportive of pulling forward (portions of) #537. In the meantime, would it make sense to merge this PR first?

@agners
Copy link
Contributor Author

agners commented Dec 22, 2022

@jwhui yes I think merging this still make sense. It fixes the build problem for the time being.

Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui jwhui merged commit e4a428f into openthread:main Dec 22, 2022
@agners agners deleted the bump-to-latest-simple-web-server branch December 22, 2022 19:23
agners added a commit to agners/ot-br-posix that referenced this pull request Dec 28, 2022
Bump Simple-Web-Server to the latest git commit. This fixes a compile
issue seen with GCC 12.2.0:

In file included from /home/sag/projects/openthread/ot-br-posix/src/web/web-service/web_server.cpp:42: /home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp: In instantiation of ‘SimpleWeb::ServerBase<socket_type>::Request::Request(const socket_type&) [with socket_type = boost::asio::basic_stream_socket<boost::asio::ip::tcp>]’:
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:460:74:   required from here
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:119:57: error: member ‘SimpleWeb::ServerBase<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >::Request::streambuf’ is used uninitialized [-Werror=uninitialized]
  119 |             Request(const socket_type &socket): content(streambuf) {
      |                                                         ^~~~~~~~~

(cherry picked from commit e4a428f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants