[rest] support Thread state change #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agners
force-pushed
the
rest-add-state-change-support
branch
from
86e0e6c
to
1017f65
Compare
wgtdkp
reviewed
May 12, 2023
Allow to enable and disable the Thread protocol operation.
The device role name is useful for other APIs as well, e.g. the REST API. Move the helper into a new common compile unit.
agners
force-pushed
the
rest-add-state-change-support
branch
from
1017f65
to
c0dbd53
Compare
Returning the OpenThread state as a number is not very REST like, use a string instead. Reuse the string returned by the D-Bus API.
agners
force-pushed
the
rest-add-state-change-support
branch
from
c0dbd53
to
f28b0ca
Compare
jwhui
reviewed
May 16, 2023
Co-authored-by: Jonathan Hui <jonhui@google.com>
agners
force-pushed
the
rest-add-state-change-support
branch
from
2e4e9bc
to
8b13968
Compare
Co-authored-by: Jonathan Hui <jonhui@google.com>
agners
force-pushed
the
rest-add-state-change-support
branch
from
8b13968
to
c069261
Compare
Reflect the new data type string returned by the state endpoint.
agners
force-pushed
the
rest-add-state-change-support
branch
from
6a6b88b
to
ecf9f8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to enable and disable the Thread protocol operation.