[mdns] let avahi use RecordBrowser to resolve addresses of a service
#1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superwhd
force-pushed
the
avahi-resolve-all-addresses
branch
from
174fbe7
to
967a1f6
Compare
sunytt
reviewed
May 22, 2023
superwhd
force-pushed
the
avahi-resolve-all-addresses
branch
from
967a1f6
to
7519c76
Compare
superwhd
changed the title
RecordBrowser to resolve addresses of a serviceRecordBrowser to resolve addresses of a service
|
openthread/openthread#9075 covers the test case. https://github.com/openthread/openthread/actions/runs/5043589092 Shows an example that the previous implementation cannot handle this. |
superwhd
force-pushed
the
avahi-resolve-all-addresses
branch
from
7519c76
to
df9fa36
Compare
bukepo
reviewed
May 23, 2023
superwhd
force-pushed
the
avahi-resolve-all-addresses
branch
from
df9fa36
to
fcc8a0a
Compare
superwhd
force-pushed
the
avahi-resolve-all-addresses
branch
from
fcc8a0a
to
0a3fd93
Compare
bukepo
reviewed
May 23, 2023
bukepo
approved these changes
May 24, 2023
bukepo
approved these changes
May 24, 2023
jwhui
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avahi only returns one of the host's addresses in the service resolution callback. However, the address may be link-local so it may not be preferred from Thread's perspective. We want to go through the complete list of addresses associated with the host and choose a routable address. Therefore we use
RecordBrowserwhich can do this job.