Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] support erasing all persistent info #1908

Merged
merged 1 commit into from Jul 13, 2023

Conversation

agners
Copy link
Contributor

@agners agners commented Jun 15, 2023

Add REST API to support erasing all persistent information, effectively factory resetting the OTBR. The implementation follows the semantic of the D-Bus API and automatically disables the Thread network.

After erasing all persistent information the dataset is cleared too. So this allows to build a new Thread network with subsequent use of the PUT method to the /node/dataset/active endpoint.

@agners
Copy link
Contributor Author

agners commented Jun 15, 2023

This replaces #1893 and implements what has been discussed in that PR.

@agners agners force-pushed the add-factory-reset-rest-api branch from 9ae6226 to 6d547cb Compare June 15, 2023 15:45
@agners
Copy link
Contributor Author

agners commented Jun 17, 2023

I think the test failure "Border Router / Border Router MATN (mDNSResponder)" is not caused by this PR, could someone trigger another test run of that test?

@wgtdkp
Copy link
Member

wgtdkp commented Jun 17, 2023

I think the test failure "Border Router / Border Router MATN (mDNSResponder)" is not caused by this PR, could someone trigger another test run of that test?

There are conflicts in third_party/openthread/repo

@agners agners force-pushed the add-factory-reset-rest-api branch from 6d547cb to 2c4b3bc Compare June 21, 2023 07:01
Add REST API to support erasing all persistent information, effectively
factory resetting the OTBR. The implementation follows the semantic of
the D-Bus API and automatically disables the Thread network.

After erasing all persistent information the dataset is cleared too. So
this allows to build a new Thread network with subsequent use of the
PUT method to the /node/dataset/active endpoint.
@agners agners force-pushed the add-factory-reset-rest-api branch from 2c4b3bc to ee59050 Compare June 21, 2023 08:10
@agners
Copy link
Contributor Author

agners commented Jun 21, 2023

There are conflicts in third_party/openthread/repo

Thanks for the hint, the issue is resolved now.

Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui changed the title [rest] support ereasing all persistent info [rest] support erasing all persistent info Jul 13, 2023
Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui jwhui merged commit 8d12b24 into openthread:main Jul 13, 2023
31 checks passed
@agners agners deleted the add-factory-reset-rest-api branch July 14, 2023 07:11
krant added a commit to krant/packages that referenced this pull request Feb 27, 2024
The patch is not needed since it is implemented in
openthread/ot-br-posix#1908
and included into the current version.

Signed-off-by: krant <aleksey.vasilenko@gmail.com>
krant added a commit to krant/packages that referenced this pull request Feb 27, 2024
The patch is not needed since it is implemented in
openthread/ot-br-posix#1908
and included into the current version.

Signed-off-by: krant <aleksey.vasilenko@gmail.com>
stintel pushed a commit to stintel/openwrt-packages that referenced this pull request Feb 27, 2024
The patch is not needed since it is implemented in
openthread/ot-br-posix#1908
and included into the current version.

Signed-off-by: krant <aleksey.vasilenko@gmail.com>
stintel pushed a commit to stintel/openwrt-packages that referenced this pull request Feb 27, 2024
The patch is not needed since it is implemented in
openthread/ot-br-posix#1908
and included into the current version.

Signed-off-by: krant <aleksey.vasilenko@gmail.com>
stintel pushed a commit to krant/packages that referenced this pull request Feb 27, 2024
The patch is not needed since it is implemented in
openthread/ot-br-posix#1908
and included into the current version.

Signed-off-by: krant <aleksey.vasilenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants