Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[telemetry] fix and refactor the PD processing #2312

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Jun 4, 2024

This PR refactors the telemetry code processing PD info to achieve two goals:

  • Handle the error when calling OT API. Previously the issue was ignored which may cause uploading wrong data.
  • Introduce helper methods for processing PD info.
  • Fix the D-BUS unit test and check more fields.

@superwhd
Copy link
Contributor Author

superwhd commented Jun 4, 2024

If this PR looks good maybe we can also refactor other sections of telemetry processing.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 39.81%. Comparing base (2b41187) to head (39948db).
Report is 673 commits behind head on main.

Files Patch % Lines
src/utils/thread_helper.cpp 0.00% 38 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2312       +/-   ##
===========================================
- Coverage   55.77%   39.81%   -15.97%     
===========================================
  Files          87       89        +2     
  Lines        6890     9866     +2976     
  Branches        0      725      +725     
===========================================
+ Hits         3843     3928       +85     
- Misses       3047     5740     +2693     
- Partials        0      198      +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superwhd superwhd changed the title [telemetry] refactor the PD processing [telemetry] fix and refactor the PD processing Jun 4, 2024
@sherysheng sherysheng self-requested a review June 4, 2024 05:46
@superwhd superwhd marked this pull request as ready for review June 4, 2024 05:50
Copy link
Contributor

@sherysheng sherysheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@superwhd superwhd requested a review from jwhui June 4, 2024 07:33
Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui merged commit 5b1a92a into openthread:main Jun 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants