-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[telemetry] fix and refactor the PD processing #2312
Conversation
If this PR looks good maybe we can also refactor other sections of telemetry processing. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
===========================================
- Coverage 55.77% 39.81% -15.97%
===========================================
Files 87 89 +2
Lines 6890 9866 +2976
Branches 0 725 +725
===========================================
+ Hits 3843 3928 +85
- Misses 3047 5740 +2693
- Partials 0 198 +198 ☔ View full report in Codecov by Sentry. |
380609b
to
322d163
Compare
322d163
to
39948db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR refactors the telemetry code processing PD info to achieve two goals: