Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix the telemetry test for verifying the RLOC16 #2313

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

superwhd
Copy link
Contributor

@superwhd superwhd commented Jun 4, 2024

Router ID is in range [0, MAX_ROUTER_ID] therefore zero is a valid RLOC16. The test case was wrongly checking if the RLOC16 is greater than zero.

An example failure: https://github.com/openthread/ot-br-posix/actions/runs/9361612569/job/25768930225?pr=2312.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.28%. Comparing base (2b41187) to head (23f0b15).
Report is 673 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2313       +/-   ##
===========================================
- Coverage   55.77%   40.28%   -15.49%     
===========================================
  Files          87       87               
  Lines        6890     9241     +2351     
  Branches        0      653      +653     
===========================================
- Hits         3843     3723      -120     
- Misses       3047     5340     +2293     
- Partials        0      178      +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwhui jwhui merged commit 251d34f into openthread:main Jun 4, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants