-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] unify MasterKey and NetworkKey #546
Conversation
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 76.85% 70.36% -6.50%
==========================================
Files 57 57
Lines 3850 3850
==========================================
- Hits 2959 2709 -250
- Misses 891 1141 +250
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:+1:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
Bug: 166553322 * origin/github/master: [web] unify MasterKey and NetworkKey (openthread#546) Change-Id: If2215b3004bc679dcdec0a767044eb34b5f357f6
As discussed in #545 , this PR changes all
NetworkKey
toMasterKey
in Web module, so the naming of this terminology is consistent with the Thread Specification.