Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] unify MasterKey and NetworkKey #546

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Conversation

tttttangTH
Copy link
Contributor

As discussed in #545 , this PR changes all NetworkKey to MasterKey in Web module, so the naming of this terminology is consistent with the Thread Specification.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #546 into master will decrease coverage by 6.49%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   76.85%   70.36%   -6.50%     
==========================================
  Files          57       57              
  Lines        3850     3850              
==========================================
- Hits         2959     2709     -250     
- Misses        891     1141     +250     
Impacted Files Coverage Δ
src/web/web-service/wpan_service.cpp 0.00% <0.00%> (-24.80%) ⬇️
src/web/web-service/wpan_service.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/web/main.cpp 0.00% <0.00%> (-70.91%) ⬇️
src/web/web-service/ot_client.cpp 0.00% <0.00%> (-68.09%) ⬇️
src/web/web-service/web_server.cpp 0.00% <0.00%> (-35.72%) ⬇️
src/utils/hex.cpp 48.83% <0.00%> (-20.94%) ⬇️
src/agent/main.cpp 78.82% <0.00%> (-12.95%) ⬇️
src/common/logging.cpp 79.41% <0.00%> (-2.95%) ⬇️
src/agent/thread_helper.cpp 70.19% <0.00%> (-1.99%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3cbbf7...e883643. Read the comment docs.

Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wgtdkp wgtdkp linked an issue Aug 21, 2020 that may be closed by this pull request
Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Copy link
Member

@jwhui jwhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@jwhui jwhui merged commit bc8825d into openthread:master Aug 26, 2020
simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
Bug: 166553322

* origin/github/master:
  [web] unify MasterKey and NetworkKey (openthread#546)
Change-Id: If2215b3004bc679dcdec0a767044eb34b5f357f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network Key vs Masterkey Naming
5 participants