[dtls] address race with fd isset #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P-158-border-router-git-ignore-missing-non-existent to master * commit '80ac484a1cb85ecfee9012dfa2f44af6da1077af': TIOP-158 | Add gitignore files
bukepo
reviewed
Aug 16, 2017
There was a problem hiding this comment.
Could you please also add the missing aContext.mDtlsServer->Start(); call in https://github.com/openthread/borderrouter/blob/master/tests/meshcop/commissioner.cpp#L643
src/agent/dtls_mbedtls.cpp
Outdated
| sockaddr_in6 src; | ||
| sockaddr_in6 dst; | ||
| struct msghdr msghdr; | ||
| struct iovec iov[1]; | ||
|
|
||
| VerifyOrExit(FD_ISSET(mSocket, &aReadFdSet)); | ||
| /* Connection is not alive yet, or is shut down */ | ||
| if (mSocket < 0) |
There was a problem hiding this comment.
Is it possible to replace line 499~503 with one line as follows
VerifyOrExit(mSocket >=0, error = OTBR_ERROR_NONE);This helps improving the code coverage.
src/agent/dtls_mbedtls.cpp
Outdated
| } | ||
|
|
||
| /* If this is nto set, then some other handle became rd/wr able. */ | ||
| if (!FD_ISSET(mSocket, &aReadFdSet)) |
There was a problem hiding this comment.
Same as above, prefer using VerifyOrExit() style.
|
Done - I need to leave now, the automated tests take about 30 minutes... I'll check back later tonight from home. |
bukepo
approved these changes
Aug 16, 2017
src/agent/dtls_mbedtls.cpp
Outdated
| ExitNow(error = OTBR_ERROR_NONE); | ||
| } | ||
| /* If this is not set, then some other handle became rd/wr able, it is not an error */ | ||
| VerifyOrExit( FD_ISSET(mSocket, &aReadFdSet), error = OTBR_ERROR_NONE); |
jwhui
approved these changes
Aug 16, 2017
jwhui
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #87
Which is a race condition that causes commissioning to fail.