[spinel-cli] add vendor path option #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
force-pushed
the
add-vendor-path-option
branch
from
aa5840d
to
ba5ad09
Compare
carlescufi
reviewed
Nov 19, 2020
| if options.vendor_path: | ||
| options.vendor_path = os.path.abspath(options.vendor_path) | ||
| vendor_path, vendor_module = os.path.split(options.vendor_path) | ||
| sys.path.insert(0, vendor_path) |
There was a problem hiding this comment.
I discussed this briefly with @rlubos today. I think this is more than warranted in this particular case, in order to solve this problem without extra complications and with very little risk. That said, I'd very much like @mbolivar-nordic to confirm this view.
There was a problem hiding this comment.
That said, I'd very much like @mbolivar-nordic to confirm this view.
Yep, I think that's reasonable if you want the vendor module to be able to import other modules next to it.
carlescufi
approved these changes
Nov 24, 2020
jwhui
approved these changes
Nov 24, 2020
jwhui
force-pushed
the
add-vendor-path-option
branch
from
d73ca75
to
a6d96d4
Compare
…d#106) There's no need to join VendorSpinelPropertyHandler class with SpinelPropertyHandler since the methods in SPINEL_PROP_DISPATCH are located in different objects anyway. This allows to move vendor properties initialization into WpanApi class initializator, therefore allowing to use custom Vendor module based on the command line argument. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Introduce a --vendor-path option which allows to provide a custom location of the vendor package. It is also possible to provide this location with SPINEL_VENDOR_PATH environmental variable. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
jwhui
force-pushed
the
add-vendor-path-option
branch
from
a6d96d4
to
bb70dc6
Compare
jwhui
pushed a commit
that referenced
this pull request
Nov 24, 2020
There's no need to join VendorSpinelPropertyHandler class with SpinelPropertyHandler since the methods in SPINEL_PROP_DISPATCH are located in different objects anyway. This allows to move vendor properties initialization into WpanApi class initializator, therefore allowing to use custom Vendor module based on the command line argument. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
--vendor-pathoption which allows to provide a custom location of the vendor package. It is also possible to provide this location withSPINEL_VENDOR_PATHenvironmental variable.