NCPInstanceBase-NetInterface: Add mesh-local address (if non-zero) in set_online()
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `set_online()` This commit makes the following changes: - In `NCPInstanceBase::set_online()` new code is added to add mesh-local address (in non-zero) when the interface is brought online. This helps address an issue where the mesh-local address was not added after a reset. - In `SpinelNCPInstance::handle_ncp_spinel_value_is()` when processing the receiving of new mesh-local address, the code checks that the old value of `mNCPMeshLocalAddress` to ensure it is non-zero before trying to remove it (this helps remove an unnecessary `require` failure message from the logs).
jwhui
approved these changes
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
In
NCPInstanceBase::set_online()new code is added to add mesh-local address (in non-zero) when the interface is brought online. This helps address an issue where the mesh-local address was not added after a reset.In
SpinelNCPInstance::handle_ncp_spinel_value_is()when processing the receiving of new mesh-local address, the codechecks that the old value ofmNCPMeshLocalAddressto ensure it is non-zero before trying to remove it (this helps remove an unnecessaryrequirefailure message from the logs).