Some sonar fixes

opentibiabr · Oct 24, 2022 · cadb78e · cadb78e
1 parent d0d3482
commit cadb78e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/creatures/players/player.cpp b/src/creatures/players/player.cpp
@@ -1682,9 +1682,8 @@ bool Player::openShopWindow(Npc* npc)
 	npc->addShopPlayer(this);
 
 	sendShop(npc);
-
-	std::map<uint16_t, uint16_t> map;
-	sendSaleItemList(getAllSaleItemIdAndCount(map));
+	std::map<uint16_t, uint16_t> inventoryMap;
+	sendSaleItemList(getAllSaleItemIdAndCount(inventoryMap));
 	return true;
 }
 
@@ -3751,7 +3750,7 @@ std::map<uint32_t, uint32_t>& Player::getAllItemTypeCount(std::map<uint32_t, uin
 	return countMap;
 }
 
-std::map<uint16_t, uint16_t>& Player::getAllSaleItemIdAndCount(std::map<uint16_t, uint16_t>& countMap) const
+std::map<uint16_t, uint16_t>& Player::getAllSaleItemIdAndCount(std::map<uint16_t, uint16_t> &countMap) const
 {
 	for (auto item : getAllInventoryItems()) {
 		if (item->getTier() > 0) {
@@ -3762,6 +3761,7 @@ std::map<uint16_t, uint16_t>& Player::getAllSaleItemIdAndCount(std::map<uint16_t
 			countMap[item->getID()] += item->getItemCount();
 		}
 	}
+
 	return countMap;
 }
 

diff --git a/src/creatures/players/player.h b/src/creatures/players/player.h
@@ -2156,8 +2156,7 @@ class Player final : public Creature, public Cylinder
 		std::map<uint32_t, uint32_t>& getAllItemTypeCount(std::map<uint32_t,
                                       uint32_t>& countMap) const override;
 		// Function from player class with correct type sizes (uint16_t)
-		std::map<uint16_t, uint16_t>& getAllSaleItemIdAndCount(std::map<uint16_t,
-                                      uint16_t>& countMap) const;
+		std::map<uint16_t, uint16_t>& getAllSaleItemIdAndCount(std::map<uint16_t, uint16_t> & countMap) const;
 		void getAllItemTypeCountAndSubtype(std::map<uint32_t, uint32_t>& countMap) const;
 		Thing* getThing(size_t index) const override;