Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/Enhancement] - No disconnect on death #147

Merged
merged 55 commits into from Mar 21, 2022
Merged

[Feature/Enhancement] - No disconnect on death #147

merged 55 commits into from Mar 21, 2022

Conversation

omeranha
Copy link
Contributor

@omeranha omeranha commented Oct 19, 2021 •
edited

Description

Credits:
0.1% @Nekiro for being so awesome.

no more disconnection when player dies

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

dudantas
dudantas previously requested changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@dudantas dudantas left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestion commits.

Ps: We had some problems pointed out by the sonar, among them a possible crash with memory leak.

@dudantas dudantas marked this pull request as draft October 23, 2021 01:12
omeranha and others added 9 commits October 22, 2021 22:15
@omeranha @dudantas
Update src/creatures/players/player.cpp
32b45e3 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/creatures/players/player.cpp
41b77b7 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/creatures/players/player.cpp
2ac71b3 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/creatures/players/player.cpp
d0b3c5c 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/creatures/players/player.cpp
0738c02 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/server/network/protocol/protocolgame.cpp
435d385 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha @dudantas
Update src/creatures/players/player.cpp
27d72d2 
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@omeranha
Merge branch 'master' into omeranha-no-disconnect-on-death
6a415af
@beats-dh
Merge branch 'master' into omeranha-no-disconnect-on-death
b50f187
@KaQn
Copy link

KaQn commented Nov 3, 2021 •
edited

If you die and then go back to kill creatures, you will get this error.
Capture

@ArturKnopik
Copy link
Contributor

We remove player stamina event on player death but player still exist in game, we need recreate this event

@dudantas
Copy link
Contributor

dudantas commented Nov 3, 2021

We remove player stamina event on player death but player still exist in game, we need recreate this event

We can stop the event if the player no longer exists

@dudantas
Copy link
Contributor

dudantas commented Nov 3, 2021

If you die and then go back to kill creatures, you will get this error. Capture

Can test the #158?

@sonarcloud

This comment was marked as outdated.

Sign in to view
@omeranha omeranha added Status: Completed Status: Pending Test This PR or Issue requires more testing labels Mar 13, 2022
@omeranha omeranha marked this pull request as ready for review March 14, 2022 01:43
@omeranha omeranha added the Status: Pending Review This PR or Issue requires a review label Mar 14, 2022
@omeranha omeranha requested a review from dudantas March 14, 2022 02:05
@doenteverde

This comment was marked as spam.

Sign in to view
@doenteverde

This comment was marked as spam.

Sign in to view
@omeranha omeranha changed the title No disconnect on death [Feature/Enhancement] - No disconnect on death Mar 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@omeranha omeranha merged commit 4f8667a into opentibiabr:master Mar 21, 2022
omeranha added a commit to opentibiabr/otservbr-global that referenced this pull request Mar 21, 2022
@omeranha
Sync with Canary pull requests (#490)
1e6150d 
Sync with canary pull requests:
opentibiabr/canary#147
opentibiabr/canary#169
opentibiabr/canary#184
opentibiabr/canary#221
@omeranha omeranha deleted the omeranha-no-disconnect-on-death branch March 21, 2022 23:23
@majestyotbr majestyotbr added Review: Completed and removed Status: Pending Review This PR or Issue requires a review Status: Pending Test This PR or Issue requires more testing labels Mar 22, 2022
@nekiro
Copy link

nekiro commented Mar 22, 2022

Interesting, you are always bragging about credits, yet you didn't gave one on this one. Nice double standards.

Original pr: otland/forgottenserver#3251

@omeranha
Copy link
Contributor Author

omeranha commented Mar 22, 2022 •
edited

Interesting, you are always bragging about credits, yet you didn't gave one on this one. Nice double standards.

Original pr: otland/forgottenserver#3251

basically in October I "cherry-picked" your pull request, yes. later that day I didn't know much about the source, even you.
I rewrote most of the code, I don't think there is no need for credits anymore.
I have 2 others pull requests there, almost an cherry-pick, and of course I did the credit.
pull request merged, please don't comment anymore, you can always go into discord if you wanna chat!

@dudantas
Copy link
Contributor

dudantas commented Mar 22, 2022 •
edited

Interesting, you are always bragging about credits, yet you didn't gave one on this one. Nice double standards.

Original pr: otland/forgottenserver#3251

I think first you need to come to a consensus: otland/forgottenserver#3999 (comment)

The credit was removed at my request, after all, the pull has been in testing for more than 4 months, there were a lot of problems and it practically had to be rewritten for our base, it didn't make sense to keep you as the author...

@andersonfaaria andersonfaaria mentioned this pull request Apr 6, 2022
Closed
@lichak232 lichak232 mentioned this pull request Apr 21, 2022
Closed
5 tasks
luan pushed a commit that referenced this pull request Jul 11, 2023
@omeranha
[Feature/Enhancement] - No disconnect on death (#147)
ca86225 
no more disconnection when player dies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majestyotbr majestyotbr majestyotbr approved these changes

@beats-dh beats-dh beats-dh approved these changes

@dudantas dudantas Awaiting requested review from dudantas

Assignees
No one assigned
Labels
Area: Datapack Global Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet