Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exp tracker #3999

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Exp tracker #3999

merged 7 commits into from
Mar 10, 2022

Conversation

ArturKnopik
Copy link
Contributor

Exp tracker feature
config:
analyserSendTrueRawExp - default false, give ability to send raw exp without multiplication by expStage

analyserSendTrueRawExp false
image

analyserSendTrueRawExp true
image

@EPuncker EPuncker added the feature New feature or functionality label Mar 10, 2022
Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the config.lua.dist entry and we good

@EPuncker EPuncker requested a review from ranisalt March 10, 2022 16:05
EPuncker
EPuncker previously approved these changes Mar 10, 2022
@EPuncker EPuncker requested review from a team March 10, 2022 16:18
This reverts commit cfc06ac.
@ramon-bernardo
Copy link
Contributor

You need to register in luascript.cpp, right?
registerEnumIn("configKeys", ConfigManager::EXP_ANALYSER_SEND_TRUE_RAW_EXP)

EPuncker
EPuncker previously approved these changes Mar 10, 2022
Copy link
Contributor

@EPuncker EPuncker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@EPuncker EPuncker merged commit bdf8fa1 into otland:master Mar 10, 2022
@ranisalt
Copy link
Member

analyserSendTrueRawExp - default false, give ability to send raw exp without multiplication by expStage

Why would someone want one option over the other?

@ramon-bernardo
Copy link
Contributor

ramon-bernardo commented Mar 10, 2022

analyserSendTrueRawExp - default false, give ability to send raw exp without multiplication by expStage

Why would someone want one option over the other?

Yes, looks like custom config for server, far from TibiaRL

@dudantas
Copy link
Contributor

dudantas commented Mar 11, 2022

It would be interesting to cite the original author (@marcosvf132): opentibiabr/canary#232

@EPuncker
Copy link
Contributor

@ranisalt
Copy link
Member

ranisalt commented Mar 11, 2022

It would be interesting to cite the original author (@marcosvf132): opentibiabr/canary#232

The code has nothing special and there is no requirement to mention the author in the license. Please stop begging for it every time 🙏 the author is free to open a pull request to this repository if they want.

@dudantas
Copy link
Contributor

dudantas commented Mar 11, 2022

The code has nothing special and there is no requirement to mention the author in the license. Please stop begging for it every time 🙏 the author is free to open a pull request to this repository if they want.

It's free to open and I'm free to comment. Am I not?
It is a common practice in open source to cite the author of the code, it is not mandatory, but it is something that strengthens ties and passes an air of respect. Not that I'm expecting that, as I've realized that this sort of thing has long since been abandoned by this community, regrettably.

And you still wonder why some people don't contribute more here?

@nekiro
Copy link
Member

nekiro commented Mar 11, 2022

The code has nothing special and there is no requirement to mention the author in the license. Please stop begging for it every time 🙏 the author is free to open a pull request to this repository if they want.

It's free to open and I'm free to comment. Am I not? It is a common practice in open source to cite the author of the code, it is not mandatory, but it is something that strengthens ties and passes an air of respect. Not that I'm expecting that, as I've realized that this sort of thing has long since been abandoned by this community, regrettably.

And you still wonder why some people don't contribute more here?

I still wonder why are you checking every single commit, every single pull request of this repository, if it's so bad and so dead

@joseluis2g
Copy link
Contributor

joseluis2g commented Mar 11, 2022

4 line codes of course need authors, we need to add jo3 as author because he was the first who exposed this code so.
edit. might be slavidodo and not jo3

@ArturKnopik ArturKnopik deleted the expTracker branch April 10, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants