Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily reward issue after moving items to protobuf #374

Closed
1 of 4 tasks
lucasgrizante opened this issue May 4, 2022 · 0 comments · Fixed by #375
Closed
1 of 4 tasks

Daily reward issue after moving items to protobuf #374

lucasgrizante opened this issue May 4, 2022 · 0 comments · Fixed by #375
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@lucasgrizante
Copy link
Contributor

Priority

Low

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

May 03 18:00:59 instance-20220216-1801 canary[3222673]: scriptId: [data/modules/scripts/daily_reward/daily_reward.lua:onRecvbyte]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: timerEvent: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]:  callbackId:[]
May 03 18:00:59 instance-20220216-1801 canary[3222673]: function: []
May 03 18:00:59 instance-20220216-1801 canary[3222673]: error [data/modules/scripts/daily_reward/daily_reward.lua:462: attempt to call field 'getItemIdByClientId' (a nil value)
May 03 18:00:59 instance-20220216-1801 canary[3222673]: stack traceback:
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         [C]: in function 'getItemIdByClientId'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:462: in function 'selectDailyReward'
May 03 18:00:59 instance-20220216-1801 canary[3222673]:         data/modules/scripts/daily_reward/daily_reward.lua:200: in function <data/modules/scripts/daily_reward/daily_reward.lua:194>]```

After the commit that removes item otb and replaces it to appearances.dat, the function getItemsIdByClientId doesn't exists anymore.

This issue happens in the days where you can grab items (not all days from daily rewards). 

### What OS are you seeing the problem on?

Linux

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct
@lucasgrizante lucasgrizante added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 4, 2022
@github-actions github-actions bot added Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing labels May 4, 2022
dudantas added a commit that referenced this issue May 4, 2022
dudantas added a commit that referenced this issue Jun 16, 2022
luan pushed a commit that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Minor impact Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant