New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Rework of the imbuement system and conversion to c++ #164
Conversation
…optimized forgottenserver NOTE: This commit request is necessary for the pull of imbuement rework and convert to c++: #164. If don't use this commit, the imbuement will crash! ItemAttributes otimization, cherry-pick of saiyansking optimized forgottenserver, very thanks. Co-authored by: @SaiyansKing.
…optimized forgottenserver NOTE: This commit request is necessary for the pull of imbuement rework and convert to c++: #164. If don't use this commit, the imbuement will crash! ItemAttributes otimization, cherry-pick of saiyansking optimized forgottenserver, very thanks. Co-authored by: @SaiyansKing.
Duration of no agressive imbuements now decaying in protection zone Fixed bug when the weapon has an elemental skill and is imbued, the imbuement doesn't work Fixed bug to update imbuement attributes even when imbued in backpack, should only be done in slot Clearing the imbuement will now remove the character's attribute. Added imbuements "tiers" to items.xml Co-Authored-By: hyresu <61813040+hyresu@users.noreply.github.com>
SonarCloud Quality Gate failed. |
Hello, I have a problem with the weapon imbuing system, if the ibue weapon that has a dmg element, the weapon only deals physical damage |
The pull request has already been closed and merged, if you are having a problem, be sure to test it with the most current server to ensure the problem is still occurring, if confirmed, you can open an issue reporting the error and we will correct. |
…optimized forgottenserver NOTE: This commit request is necessary for the pull of imbuement rework and convert to c++: #164. If don't use this commit, the imbuement will crash! ItemAttributes otimization, cherry-pick of saiyansking optimized forgottenserver, very thanks. Co-authored by: @SaiyansKing.
) NOTE: The pull request of optimization and enhancement of ItemAttributes is needed for this commit: 59e8aaa. If don't use the "ItemAttributes enhancent" commit, the imbuement will crash! Thanks to @lgrossi for the reviews made and for helping to solve several problems. Thanks @Glatharth for provide the script for convert tables lua in items.xml: https://gist.github.com/dudantas/548fdbc3c521327c7d5320e27adba8fb The system has been completely converted to c++ Fixed bugs and adapted the operation to be the same as global tibia Possibility to imbue the equipped item Added config.lua key for enable/disable the use of storages by the imbuement system (togleImbuementShrineStorage) The imbuement of each item is now configured in items.xml in the following settings: <attribute key="imbuementslot" value="3"> <attribute key="elemental damage" value ="3"/> <attribute key="life leech" value ="3"/> <attribute key="mana leech" value ="3"/> <attribute key="critical hit" value ="3"/> <attribute key="elemental protection death" value ="3"/> <attribute key="elemental protection earth" value ="3"/> <attribute key="elemental protection fire" value ="3"/> <attribute key="elemental protection ice" value ="3"/> <attribute key="elemental protection energy" value ="3"/> <attribute key="elemental protection holy" value ="3"/> <attribute key="increase speed" value ="3"/> <attribute key="skillbost axe" value ="3"/> <attribute key="skillbost sword" value ="3"/> <attribute key="skillbost club" value ="3"/> <attribute key="skillbost shielding" value ="3"/> <attribute key="skillbost distance" value ="3"/> <attribute key="skillbost magic level" value ="3"/> <attribute key="increase capacity" value ="3"/> </attribute> Where the "imbuementslot" value is from 1 to 3 and the imbuement name values are also from 1 to 3, which is the imbuement level (basic, intricate or powerful), the name must be placed as above, as it is from the name that the value of each imbuement is called by ItemParse.
Description
Thanks to @lgrossi for the reviews made and for helping to solve several problems.
Thanks to @hyresu for correcting some behaviors of the global and for the fix moving map deletion to outside the loop to avoid memory reference crash on Game::checkImbuements function
The system has been completely converted to c++
Fixed bugs and adapted the operation to be the same as global tibia
Possibility to imbue the equipped item
The imbuement of each item is now configured in items.xml in the following settings:
Where the "imbuementslot" value is from 1 to 3 and the imbuement name values are also from 1 to 3, which is the imbuement level (basic, intricate or powerful), the name must be placed as above, as it is from the name that the value of each imbuement is called by ItemParse.
Type of change
Checklist