Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unjustified death #1789

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix: unjustified death #1789

merged 2 commits into from
Nov 8, 2023

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Nov 8, 2023 •
edited
Loading

The function that clears the attackedSet was being executed before onKilledCreature:

canary/src/creatures/creature.cpp

Line 651 in a9c391b

attackerPlayer->removeAttacked(getPlayer());

Which caused the kills/skulls bug.

@dudantas dudantas linked an issue Nov 8, 2023 that may be closed by this pull request
PVP dont get Red Skull #1785
Closed
5 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 7bba687 into main Nov 8, 2023
36 checks passed
@dudantas dudantas deleted the fix-unjustified-death branch November 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsongabriel elsongabriel elsongabriel approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PVP dont get Red Skull
2 participants
@dudantas @elsongabriel