Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: small adjustment to 'hasTraceableContext()' #2374

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

luanluciano93
Copy link
Contributor

Description

  • The 'checkCreatureWalk' function is of the 'Game' class and not 'Creature' as advertised.
  • 'FUNCTION' was only returning the name of the function and not the class, so it had been necessary to add it to 'hasTraceableContext()'.

Behaviour

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

LeeoMacedo and others added 30 commits August 20, 2023 10:17
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
@luanluciano93 luanluciano93 changed the title Fix name checkcreaturewalk improve: small adjustment to 'hasTraceableContext()' Mar 4, 2024
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Apr 28, 2024
@github-actions github-actions bot removed the Stale No activity label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants