fix: onDeEquip properly handled at logout/death

[luanluciano93]

We didn't deequip items on logout/death but we equip everytime the player login.
That way onDeEquip didn't work correctly as intended.
following example code shows what the problem is:

local test = MoveEvent()

function test.onEquip(player, item, slot, isCheck)
	player:setMaxHealth(player:getMaxHealth() + 100)
	return true
end

test:type("equip")
test:slot("ring")
test:id(9393)
test:level(100)
test:register()

function test.onDeEquip(player, item, slot, isCheck)
	player:setMaxHealth(player:getMaxHealth() - 100)
	return true
end

test:type("deequip")
test:slot("ring")
test:id(9393)
test:level(100)
test:register()

The above would have resulted on every logout/login that the HP would increase by 100 but not decrease on logout/death
which is now fixed

credits: EvilHero90 (based TFS PR)

[phacUFPE]

I'm leaving a review that blocks the merge because it has an issue in the code that crash the builds. I'm leaving the solution, but GitHub Actions also complained about it.

[rafalolszewski94]

This still doesn't fix the issue.

[rafalolszewski94]

It should be

g_moveEvents().onPlayerEquip(getPlayer(), item, static_cast<Slots_t>(slot), false);

instead of

g_moveEvents().onPlayerDeEquip(getPlayer(), item, static_cast<Slots_t>(slot));