Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vip groups #2635

Merged
merged 19 commits into from
May 24, 2024
Merged

feat: vip groups #2635

merged 19 commits into from
May 24, 2024

Conversation

phacUFPE
Copy link
Contributor

Description

Adds the VIP Groups system and separates VIP methods from player file into a new file.

Behaviour

Actual

2024-05-17.16-49-39.mp4

Expected

2024-05-17.16-42-30.mp4

Fixes #89

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Create a new vip group
  • Add a player to a group
  • Edit the group
  • Remove the group

Test Configuration:

  • Server Version: 3.1.2 (Latest)
  • Client: 13.32.14520
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

phacUFPE and others added 6 commits May 14, 2024 07:52
changes:
- Moved vip methods into new file and new class
- Created all database methods to create, insert, update, delete vip groups and players in vip groups
- Updated all necessary protocolgame methods
@phacUFPE phacUFPE changed the title Feat vip groups feat: vip groups May 17, 2024
@elsongabriel elsongabriel merged commit 1df6ce5 into main May 24, 2024
41 checks passed
@elsongabriel elsongabriel deleted the feat_vip_groups branch May 24, 2024 11:57
@slawkens
Copy link
Contributor

Hello, just wanted to let you know:

After importing the latest schema.sql to clean db, following error appears:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIP Groups not being able to be created
5 participants