Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cask and kegs #2647

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

omarcopires
Copy link
Contributor

  1. Now there will be no more errors when using empty flasks on incorrect fields.
  2. The empty flasks will be sent to the store inbox instead of the backpack.

A mechanism to block the trade and movement of the potions in the store inbox still needs to be adjusted.

Co-Authored-By: Leilani A. <168607226+kaleohanopahala@users.noreply.github.com>
@Mirkaanks
Copy link
Contributor

The flask used from the ground should also work.

kaleohanopahala

This comment was marked as outdated.

@omarcopires
Copy link
Contributor Author

The flask used from the ground should also work.

in my tests I was able to use them from the ground directly on the target, could you test with the latest changes?

@kaleohanopahala
Copy link

I noticed that you check if not charges then before removing the target. This probably isn't correct because charges will always be a number after being subtracted from flaskCount.
Also, you remove the target only if not charges, which doesn't seem correct since charges can be zero in some cases without requiring the target to be removed.

I believe that if the inbox has an issue or is full, it should be moved to the regular inventory, just like in the global environment.

kaleohanopahala

This comment was marked as resolved.

@majestyotbr
Copy link
Contributor

Is this ready for tests?

@Mirkaanks

This comment was marked as spam.

@omarcopires
Copy link
Contributor Author

Is this ready for tests?

YES!

Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving as suggestion, beucase I think that this shouldn't be mandatory, it just simplify the usage of this feature and makes it like it is in Tibia Global.

data/scripts/actions/objects/cask_and_kegs.lua Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants