Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing summon searching player target and icons update #395

Merged
merged 2 commits into from
May 27, 2022

Conversation

dudantas
Copy link
Contributor

Fixed the bug when the player was attacking a creature and summoned, the summon would not attack the creature until the player stopped attacking and attacked again.

Fixed the icon of creatures that use the "creature:addSummon" function
Added Game::reloadCreature functions
Rework on function "Creature::setMaster", somes functions were centralized within the setMaster, avoiding repetitions:

Creature::setTarget
Creature::setFollowCreature
Creature::setDropLoot
Creature::setSkillLoss

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 6b56fbf into main May 27, 2022
@majestyotbr majestyotbr deleted the fix-summons-target-and-icons branch May 29, 2022 21:50
@dudantas dudantas linked an issue Jun 7, 2022 that may be closed by this pull request
1 task
luan pushed a commit that referenced this pull request Jul 11, 2023
Fixed the bug when the player was attacking a creature and summoned, the summon would not attack the creature until the player stopped attacking and attacked again.

Fixed the icon of creatures that use the "creature:addSummon" function
Added Game::reloadCreature functions
Rework on function "Creature::setMaster", somes functions were centralized within the setMaster, avoiding repetitions:
Creature::setTarget
Creature::setFollowCreature
Creature::setDropLoot
Creature::setSkillLoss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Summons don't target the master target when being invoked
3 participants