Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync missing weapons #405

Merged
merged 36 commits into from
Jul 19, 2022
Merged

Sync missing weapons #405

merged 36 commits into from
Jul 19, 2022

Conversation

Aerwix
Copy link
Contributor

@Aerwix Aerwix commented Jun 4, 2022

We were missing this files:

Burst Arrow
Diamond Arrow
Viper Star
Poison Arrow

P.S. I didn't checked formulas, I remember one server had excesive value with poison arrows. lol

Aerwix and others added 30 commits October 27, 2021 11:12
@Aerwix
Bug Solution: Magic Wall not decaying
39ab261 
Magic wall wasnt decaying to 0 because it have the wrong id (2129 to 2128)
@Aerwix
Merge branch 'opentibiabr:master' into master
1a2be7c
@Aerwix
Small Fix: Magic Wall & Wild Growt (SafeSprites) werent decayingh
8ff60e2 
Just adding decay for the 'safe' runes of Magic Wall and Wild Growth Rune.
@Aerwix
HotFix: Safe Magic Wall
6cad1c0 
Safe Magic Wall isn't walkable anymore.
@dudantas
Merge branch 'master' into master
6a08d7b
@Aerwix
Merge branch 'opentibiabr:master' into master
c839051
@Aerwix
Merge branch 'opentibiabr:master' into master
c42081a
@Aerwix
Merge branch 'opentibiabr:master' into master
21296a2
@Aerwix
Merge branch 'opentibiabr:master' into master
337b15d
@Aerwix
Merge branch 'opentibiabr:master' into master
eca3035
@Aerwix
Merge branch 'opentibiabr:master' into master
ee5fc7c
@Aerwix
Merge branch 'opentibiabr:master' into master
ccfef38
@Aerwix
Merge branch 'opentibiabr:master' into master
4ec6ab0
@Aerwix
Fix to Custom Currency at NPC
68aa5f9 
Adding missing code
@Aerwix
Merge branch 'opentibiabr:master' into master
8e1d245
@Aerwix
Merge branch 'opentibiabr:master' into master
170177f
@Aerwix
Merge branch 'opentibiabr:master' into master
e9d2d62
@Aerwix
Merge branch 'opentibiabr:master' into master
c22d40e
@Aerwix
Merge branch 'opentibiabr:master' into master
43ee34c
@Aerwix
Merge branch 'opentibiabr:master' into master
e71d8a7
@Aerwix
Merge branch 'opentibiabr:main' into main
9f071b6
@Aerwix
Merge branch 'opentibiabr:main' into main
026e30e
@Aerwix
Merge branch 'opentibiabr:main' into main
c4352db
@Aerwix
Merge branch 'opentibiabr:main' into main
7571334
@Aerwix
Merge branch 'opentibiabr:main' into main
daa8164
@Aerwix
Merge branch 'opentibiabr:main' into main
7734e97
@Aerwix
Merge branch 'opentibiabr:main' into main
7f668c4
@Aerwix
Merge branch 'opentibiabr:main' into main
661b828
@Aerwix
Merge branch 'opentibiabr:main' into main
4083fe2
@Aerwix
Merge branch 'opentibiabr:main' into main
5142620
@sonarcloud
Copy link

sonarcloud bot commented Jun 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@majestyotbr
Copy link
Contributor

https://github.com/opentibiabr/canary/blob/main/data/scripts/weapons/scripted_weapons.lua

@Aerwix
Copy link
Contributor Author

Aerwix commented Jun 8, 2022

https://github.com/opentibiabr/canary/blob/main/data/scripts/weapons/scripted_weapons.lua

Actually this is not working. Im running a clean datapack and it have that file and it's not working :) Gonna check to what's goin on there

@Aerwix
Copy link
Contributor Author

Aerwix commented Jun 8, 2022 •
edited

Actually IDs are incorrect, gonna update this.
Burst Arrow is working now ✔️
Viper Star and Poison Arrow are throwing but not setting poison on target ❎
Diamond Arrow isn't shooting ❎

Also check the other repo, there are the files 🤡
https://github.com/opentibiabr/otservbr-global/tree/main/data/scripts/weapons

Image:
bugArrows

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2022

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 9, 2022
@dudantas dudantas merged commit 647b005 into opentibiabr:main Jul 19, 2022
luan pushed a commit that referenced this pull request Jul 11, 2023
@Aerwix
[Fix] convert burst and poison arrow to client id (#405)
1113a09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

Assignees
No one assigned
Labels
Area: Datapack Global Stale No activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aerwix @majestyotbr @dudantas