Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Automatically download world otbm in folder if file doesn't exist on server start #437

Merged
merged 12 commits into from
Jul 18, 2022

Conversation

omeranha
Copy link
Contributor

Description

  • New feature (non-breaking change which adds functionality)

@gesior

This comment was marked as off-topic.

@omeranha

This comment was marked as off-topic.

@Znote

This comment was marked as outdated.

src/map/map.cpp Outdated Show resolved Hide resolved
@omeranha omeranha changed the title [Enhancement] - Automatically download world.zip in world folder if zip file doesn't exist on server start [Enhancement] - Automatically download world otbm in folder if file doesn't exist on server start Jul 15, 2022
@dudantas
Copy link
Contributor

dudantas commented Jul 15, 2022

third: since you don't know/understand anything about our projects, i will explain it to you, this dropbox link is the new official download of our updated global map, in the next release the we will remove the map zip from repo.

This violates dropbox terms of service. This is also a security vulnerability. And generally a terrible idea.

I marked it as outdated as we update to stay in the releases. This was something that we had already defined internally as the best alternative, even by creating a "history" linking the map to each release created, but avoiding increasing the history of the repository with binary. Several days ago we had already defined that it would be in the releases, we just hadn't updated it yet. My suggestion is that when you have this type of doubt, look for our discord, because it is the place where we usually discuss these matters, but I believe you know that because you participate there and you must have noticed that it is very busy. Anyway, thanks for your observation, even though this doesn't violate any dropbox terms, it wasn't our idea to keep it there when merging.

Added toggleMapDownload and mapDownloadUrl tags on configmanager for help with download map
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability D 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@omeranha omeranha merged commit 5e42475 into main Jul 18, 2022
@omeranha omeranha deleted the download-map branch July 18, 2022 01:37
luan pushed a commit that referenced this pull request Jul 11, 2023
…oesn't exist on server start (#437)

If toggleDownloadMap if false, then the mapDownloadUrl will not be used
If a map with the name already exists in the world folder, the map will not be downloaded even if the toggleDownloadMap is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants