Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Build of docker and linux #440

Merged
merged 2 commits into from
Jul 17, 2022
Merged

[Fix] Build of docker and linux #440

merged 2 commits into from
Jul 17, 2022

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented Jul 15, 2022 •
edited

Fix the compilation in the docker environment and the error that occurred with linux when it was going to compile on a new "VM" machine.

What happened is that the protobuf was updated and our proto files were generated in an old version, with this PR they are ready to work with the latest version of the protobuf made available by vcpkg

@beats-dh beats-dh added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Priority: Medium This issue may be impactful and needs some attention. Area: Source Status: Pending Review This PR or Issue requires a review labels Jul 15, 2022
@beats-dh beats-dh closed this Jul 15, 2022
@beats-dh beats-dh reopened this Jul 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@beats-dh beats-dh changed the title [Fix] Build docker [Fix] Build of docker and linux Jul 15, 2022
@CleberMoreira
Copy link

#error regenerate this file with a newer version of protoc.
protoc

(funciona na segunda tentativa cmake --build linux-release igual antes),
okokok

Ubuntu 20.04

[my bad se não for esse o fix ou se eu estiver comentando algo offtopic.] obg 😄

@beats-dh
Copy link
Collaborator Author

#error regenerate this file with a newer version of protoc. protoc

(funciona na segunda tentativa cmake --build linux-release igual antes), okokok

Ubuntu 20.04

[my bad se não for esse o fix ou se eu estiver comentando algo offtopic.] obg 😄

Oops, for everything to work correctly the vcpkg has to be updated, because the protobuf lib was updated if you use this rp with a different version of the protobuf it will always give an error.

@dudantas dudantas merged commit 90e7561 into opentibiabr:main Jul 17, 2022
@beats-dh beats-dh deleted the test-fixe-docker branch July 17, 2022 01:18
luan pushed a commit that referenced this pull request Jul 11, 2023
@beats-dh
[Fix] Build of docker and linux (#440)
d9b2b38 
Fixed the compilation in the docker environment and the error that occurred with linux when it was going to compile on a new "VM" machine.

What happened is that the protobuf was updated and our proto files were generated in an old version, with this change they are ready to work with the latest version of the protobuf made available by vcpkg

Note: vcpkg needs to be updated to the most current version for it to work properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@marcosvf132 marcosvf132 Awaiting requested review from marcosvf132

Assignees
No one assigned
Labels
Area: Source Priority: Medium This issue may be impactful and needs some attention. Status: Pending Review This PR or Issue requires a review Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@beats-dh @CleberMoreira @dudantas @majestyotbr