Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clone items and crash if classicEquipmentSlots is true #464

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Fix clone items and crash if classicEquipmentSlots is true #464

merged 2 commits into from
Jul 27, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Jul 27, 2022 •
edited
Loading

Resolves #457

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

gerotib
gerotib approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@gerotib gerotib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I cant reproduce reported bugs, and see no issues with some other stack/equip tests.

@dudantas
Copy link
Contributor Author

dudantas commented Jul 27, 2022 •
edited
Loading

Seems fine. I cant reproduce reported bugs, and see no issues with some other stack/equip tests.

Thanks for feedback!

@dudantas dudantas merged commit b7a69ab into main Jul 27, 2022
@dudantas dudantas deleted the fix-clone-items-related-to-classic-equipments-slots branch December 4, 2022 04:22
luan pushed a commit that referenced this pull request Jul 11, 2023
@dudantas
Fixed clone items and crash if classicEquipmentSlots is true (#464)
be3fb37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerotib gerotib gerotib approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
Canary Roadmap
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item cloning and server crash with 'classicEquipmentSlots = true'
2 participants
@dudantas @gerotib