Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Client debug on depot search (255+ items) #496

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[Fix] Client debug on depot search (255+ items) #496

merged 1 commit into from
Sep 1, 2022

Conversation

marcosvf132
Copy link
Contributor

Description

There is a debug on client when you search for an item that has more than 255 slots. For example, if you search for a 'mace' and you have 256 mace on your depot and you click on search, the client will debug.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit d14c31c into opentibiabr:main Sep 1, 2022
@dudantas dudantas deleted the fix-depot-search-debug branch September 1, 2022 18:50
@dudantas dudantas restored the fix-depot-search-debug branch September 1, 2022 18:50
JoaoCRDias pushed a commit to JoaoCRDias/canary that referenced this pull request Nov 2, 2022
@marcosvf132 @JoaoCRDias
[Fix] Client debug on depot search (255+ items) (opentibiabr#496)
c505680 
There is a debug on the client when you search for an item that has more than 255 slots. For example, if you search for a 'mace' and you have 256 mace on your depot, and you click on search, the client will debug.
luan pushed a commit that referenced this pull request Jul 11, 2023
@marcosvf132
[Fix] Client debug on depot search (255+ items) (#496)
a27c19b 
There is a debug on the client when you search for an item that has more than 255 slots. For example, if you search for a 'mace' and you have 256 mace on your depot, and you click on search, the client will debug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudantas dudantas dudantas approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
Canary Roadmap
Status: PRs Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcosvf132 @dudantas @majestyotbr