[Enhancement] - Optimize decay #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Costallat
force-pushed
the
master
branch
27 times, most recently
from
40b5a98
to
88b2e44
Compare
dudantas
approved these changes
Oct 23, 2021
lgrossi
reviewed
Nov 27, 2021
lgrossi
reviewed
Nov 27, 2021
lgrossi
reviewed
Nov 27, 2021
Co-Authored-By: Jakub <38609240+SaiyansKing@users.noreply.github.com> fix location decay.cpp
Co-Authored-By: Jakub <38609240+SaiyansKing@users.noreply.github.com>
Co-Authored-By: Jakub <38609240+SaiyansKing@users.noreply.github.com>
Co-Authored-By: Jakub <38609240+SaiyansKing@users.noreply.github.com>
Co-Authored-By: Jakub <38609240+SaiyansKing@users.noreply.github.com>
beats-dh
force-pushed
the
Optimized-new-decay-algorithm
branch
from
bb98e96
to
cfeddb7
Compare
|
SonarCloud Quality Gate failed. |
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Co-Authored-By: Jakub @SaiyansKing jakubkubina@hotmail.com From: https://github.com/opentibiabr/optimized_forgottenserver/tree/master Reworked the decay, so the problems with the CPU spike are over, as well as other problems with the decay, like some items resetting the duration when equip/deequip. New functions: Game::stopDecay(item) Container::stopDecaying() DepotChest::isRemoved() DepotLocker::isRemoved() Inbox::isRemoved() Item::stopDecaying() From function: decreaseDuration(time) To: setDurationTimestamp(timestamp) New file decay.cpp/h Decay::startDecay(item, duration) Decay::stopDecay(item, timestamp) Decay::checkDecay() New attribute: ITEM_ATTRIBUTE_DURATION_TIMESTAMP
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Jakub @SaiyansKing jakubkubina@hotmail.com
From: https://github.com/opentibiabr/optimized_forgottenserver/tree/master
Reworked the decay, so the problems with the CPU spike are over, as well as other problems with the decay, like some items resetting the duration when equip/deequip.
New functions:
Game::stopDecay(item)
Container::stopDecaying()
DepotChest::isRemoved()
DepotLocker::isRemoved()
Inbox::isRemoved()
Item::stopDecaying()
From function:
decreaseDuration(time)
To:
setDurationTimestamp(timestamp)
New file decay.cpp/h
Decay::startDecay(item, duration)
Decay::stopDecay(item, timestamp)
Decay::checkDecay()
New attribute: ITEM_ATTRIBUTE_DURATION_TIMESTAMP