Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] rework in subactions from gamestore #701

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

dudantas
Copy link
Contributor

Description

Some subactions were repeated, which meant that the purchase of some offers did not work properly.
Cataloged the subactions of each offer, and added to enum, to avoid repetitions.

Behaviour

Actual

When buying, some offers redirects to the id of another

Expected

Now when buying the offer with subaction, it will direct to the correct id

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Buy for example the charm expansion or any of the third slots (prey or hunting task) and it will redirect to bless. With this pull request, purchases will be made correctly.

@dudantas
Copy link
Contributor Author

Testado, só Permanent Prey Slot não está indo pro caminho certo.

Tem certeza? Eu testei e ele está comprando certinho também.

@dudantas
Copy link
Contributor Author

Testado, só Permanent Prey Slot não está indo pro caminho certo.

Tem certeza? Eu testei e ele está comprando certinho também.

sim peguei o dois arquivo e joguei na base , estou clicando pelo atalho PREY, Não pela store

Fixado!

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dudantas dudantas merged commit 14189ce into opentibiabr:main Dec 19, 2022
luan pushed a commit that referenced this pull request Jul 11, 2023
Some subactions were repeated, which meant that the purchase of some offers did not work properly.
Catalogued the subactions of each offer, and added to enum, to avoid repetitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants