Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Features: Party list support #2433

Merged
merged 6 commits into from
Mar 31, 2021
Merged

Features: Party list support #2433

merged 6 commits into from
Mar 31, 2021

Conversation

dex-89
Copy link
Contributor

@dex-89 dex-89 commented Feb 18, 2021 •
edited

Thanks: @marcosvf132

Credits: @SaiyansKing

@dex-89 dex-89 added Status: In Progress Type: Missing Content Content that was not yet implemented or is not following the accepted standards labels Feb 18, 2021
@phacUFPE phacUFPE added Status: Completed Work done, ready for review and test Test: Completed Tested and it is working properly and removed Status: In Progress labels Feb 18, 2021
phacUFPE
phacUFPE approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works!

@dex-89 dex-89 changed the title Features: Party & vocation support Features: Party list support Feb 18, 2021
@gerotib
Copy link
Contributor

gerotib commented Feb 23, 2021

If party member is not on screen and log out, he will stay on party list:
elo

@dex-89
Copy link
Contributor Author

dex-89 commented Feb 24, 2021

If party member is not on screen and log out, he will stay on party list:
elo

Probably its ok. I check this at global

@phacUFPE
Copy link
Contributor

phacUFPE commented Mar 5, 2021 •
edited

If party member is not on screen and log out, he will stay on party list:
elo

Probably its ok. I check this at global

at global the character is removed from party list on logout. need to fix it
@dex-89

@majestyotbr majestyotbr merged commit 0f8100f into opentibiabr:develop Mar 31, 2021
wizardlink pushed a commit to Hydractify/otservbr-global that referenced this pull request Apr 2, 2021
@dex-89 @wizardlink
Features: Party list support (opentibiabr#2433)
0209d9a 
Thanks: @marcosvf132

Credits: @SaiyansKing
@dex-89 dex-89 deleted the party branch April 10, 2021 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Costallat Costallat Costallat approved these changes

@adrianomengue adrianomengue adrianomengue approved these changes

@phacUFPE phacUFPE phacUFPE approved these changes

@majestyotbr majestyotbr majestyotbr approved these changes

@Bipbop69 Bipbop69 Bipbop69 approved these changes

Assignees
No one assigned
Labels
Status: Completed Work done, ready for review and test Test: Completed Tested and it is working properly Type: Missing Content Content that was not yet implemented or is not following the accepted standards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dex-89 @gerotib @phacUFPE @Costallat @adrianomengue @majestyotbr @Bipbop69