This repository has been archived by the owner on May 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the monsters have double exp is correct. Inside the skills tab it's still 100% exp, not 200% data/scripts/globalevents/others/startup.lua
|
13 tasks
This PR is stale because it has been open 45 days with no activity. |
This was
linked to
issues
Apr 27, 2022
guispiller
approved these changes
May 9, 2022
majestyotbr
approved these changes
May 12, 2022
majestyotbr
pushed a commit
to opentibiabr/canary
that referenced
this pull request
May 27, 2022
This works directly with: opentibiabr/otservbr-global#471
JoaoCRDias
pushed a commit
to JoaoCRDias/otservbr-global
that referenced
this pull request
Jul 27, 2022
This works directly with: opentibiabr/canary#239
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Area: Datapack
Stale
No activity
Status: Pending Review
This PR or Issue requires a review
Status: Pending Test
This PR or Issue requires more testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour
Actual
This PR works directly with: opentibiabr/canary#239
Fix:
On login you have one "XP Gain Rate", when you get experience this value changed.
Event schedule only display info, but doesn't work.
Expected
Formulae Tibia Wiki
Fixes
global.lua & statup.lua
global.lua -> globalevents\others\startup.lua
all events rates variables.getEventSSkill, getEventSExp and getEventSLoot
now load after events module.GlobalStorage.XpDisplayMode -> 1
player.lua
onGainExperience
; AddedpreyBonus & staminaBoost
variable.now use simple rule of 3...
Rat: if 5 exp --- 100% | ? exp --- 150% so... 5 / 100 * 150 = 7(BaseXpGain + etc) see Rat
lib\core\functions.lua
getLootRandom
approximate to real tibia.getRateFromTable
when doesn't have stages, return default.configmanager.cpp & configmanager.h
RATE_USE_STAGES
boolean configrateUseStages = true
.-fixed
RATE_EXPERIENCE
.creaturescript\others\login.lua
setBaseXpGain
, now work with events too.spawn.cpp & spawn.h
MINSPAWN_INTERVAL
, addMonster with min value.interval
to30000
, less check time.game.cpp, scripts\luascript.cpp & protocolstatus.cpp
otserv.cpp & config.lua.dist
events.xml
NOTE: exprate, lootrate, spawnrate or skillrate in 100, it's default value.
Type of change
How Has This Been Tested
Rat Test 1: without event, rateExp x1 + stamina : 150% = 7.5
Rat Test 2: with event +100%, rateExp 100% + prey 40% + store 50% + stamina x1.5 : 435% = 21,75
Test Configuration:
Server Version:
Client: Client 12.85
Operating System: Windows 11
Checklist