Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix killing in the name of... tasks #731

Merged
merged 24 commits into from
Aug 5, 2022
Merged

Fix killing in the name of... tasks #731

merged 24 commits into from
Aug 5, 2022

Conversation

rigis1
Copy link
Contributor

@rigis1 rigis1 commented Jul 24, 2022

Description

Few problems will be resolved in #736

Adds:

  • boss points, now after finish tasks when you have boss activated but not finished you will be rewarded with boss point
  • extra points, now when you have low amount of points when you have level 130+ you will be rewarded with extra
  • free boss, first time kill boss from lower tier will not cost boss points
  • points cap, when you reach point cap you will not receive points after complete task
  • djinns task
  • pirate task
  • daniel steelsoul tasks
  • djinn boss: merikh the slaughterer

Fix:

  • grizzly adams now will not give you tasks that belongs to others npc.
  • ranks promotion, now after collect proper amount of points you will receive rank promotion
  • achievements after boss kill, now you have to kill boss to receive achievement
  • questlogs description
  • demon task, now is not repeatable
  • minotaur task
  • necromancer task

Changes:

  • changed from quest log kill counter to storage kill counter, now kills will not send you quest log update spam
  • messages from grizzly adams, now will be more like global
  • questlog entries, now will be more like global
  • boss script from uid to position
  • tasks are now grouped by npc

Fixes

#686
#708

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Changed from quest log kill counter  to storage kill counter.
Fixed:
boss points,
achivements after boss kill,
messages from npc,
ranks promotion,
points giving after 130 lvl
@rigis1 rigis1 marked this pull request as draft July 24, 2022 19:36
rigis1 added 13 commits July 24, 2022 21:37
line contains trailing whitespace
alternative killcounter for quest log description purpose
replace few PLACEHOLDER's
fix for medusa and draken
now you can't repeat demon task
update questlog,
fix mino and necro task.
reported by reviewdog
update questlog,
fix djinns
+boss Merikh the Slaughterer
update questlog,
fix pirate task
update questlog,
fix tasks
@rigis1 rigis1 changed the title Fix grizzly adams tasks Fix killing in the name of... tasks Jul 27, 2022
sorted questlog,
removed useless / doubled questlogs
changed from point static value to static value,
removed useless / doubled tasks entry,
group tasks
from uid to position
@rigis1 rigis1 mentioned this pull request Jul 28, 2022
11 tasks
@rigis1 rigis1 marked this pull request as ready for review July 28, 2022 20:16
remove duplicates
due map changes
@majestyotbr majestyotbr linked an issue Jul 29, 2022 that may be closed by this pull request
11 tasks
adjusted names to pattern
@majestyotbr majestyotbr linked an issue Aug 5, 2022 that may be closed by this pull request
5 tasks
@majestyotbr
Copy link
Contributor

Thanks for your contribution.
Updated otservbr-global map available in:
https://github.com/opentibiabr/otservbr-global/releases/download/stable-v1.4.0/otservbr.otbm

@majestyotbr majestyotbr merged commit a283143 into opentibiabr:main Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants