This repository has been archived by the owner on May 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 162
Fix items ids and npc player:getName function, add water pipe action #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dfd2324.
This reverts commit fb63947.
Corrected Giant Shimmering Pearl names. Added sell price to wedding ring and white pearl.
Corrected wild flowers clientid
Changed to correct heaven blossom clientid in npcConfig.shop
Fix to stop NPC saying "Oh |PLAYERNAME|, thank god...".
Changed shop item to correct ankh
Corrected drop % and count to match wiki.
Water Pipe smoke action.
rigis1
reviewed
Aug 3, 2022
rigis1
reviewed
Aug 3, 2022
majestyotbr
approved these changes
Aug 5, 2022
rigis1
approved these changes
Aug 5, 2022
majestyotbr
approved these changes
Aug 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor changes to several files.
Behaviour
Actual
Expected
NPC Hanna should buy Wedding Ring and White Pearl.
Both giant shimmering pearls should be named 'giant shimmering pearl'
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
NPC Yasir should buy the wild flowers item (clientId 25691) for 120gold and heaven blossom (clientId 5921) for 50gold.
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
After killing 5,000 minotaurs for Budrik, and completing the quest, you should have access to The Horned Fox boss room.
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
NPC Padreia should refer to the players name when the player asks for a mission.
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
Monster Undead Elite Gladiator drop rates should be different to what is occurring.
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Behaviour
Actual
Expected
Using any of the water pipe items (2974,2980,21323) should result in a POFF at the location of the water pipe.
Fixes
Type of change
Please delete options that are not relevant.
How Has This Been Tested
Test Configuration:
Checklist