Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix redskull and blackskull droploot #757

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

majestyotbr
Copy link
Contributor

@majestyotbr majestyotbr commented Aug 18, 2022

Description

Fix redskull and blackskull droploot.

Behaviour

Actual

When killing a player with red skull or black skull, it shows an error on distro.

Expected

When killing a player with red skull or black skull, it shows no error on distro.

Fixes

#745

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr linked an issue Aug 18, 2022 that may be closed by this pull request
5 tasks
@majestyotbr majestyotbr changed the title Fix blackskull droploot Fix redskull and blackskull droploot Aug 18, 2022
@opentibiabr opentibiabr deleted a comment from Darkedo Aug 18, 2022
Copy link

@CleberMoreira CleberMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as intended and no errors were displayed in console when both Red Skull and Black Skull died ✅
all_ok_skulls

@carlospess0a
Copy link

Worked fine for me.

@majestyotbr majestyotbr merged commit 6b35688 into main Aug 23, 2022
@majestyotbr majestyotbr deleted the fix-blackskull-droploot branch August 23, 2022 02:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when killing player blackskull
6 participants