Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix Mortimer dialogue loop when delivering the pickaxe #778

Merged

Conversation

lucastsantos
Copy link
Contributor

Description

Mortimer was not allowing the player to complete the "Joining the Explorers" quest.
The player was getting stuck into a loop of always having to provide a dwarven pickaxe and not advancing the questline.

Behaviour

Actual


Expected

The expected was to fill the quest and move to another missions.


Fixes

Angus has a different value for this section, so I've aligned to Mortimer set the same value:

if player:removeItem(4845, 1) then
player:setStorageValue(Storage.ExplorerSociety.JoiningTheExplorers, 5)
player:setStorageValue(Storage.ExplorerSociety.QuestLine, 5)
npcHandler:say({
"Excellent, you brought just the tool we need! Of course it was only a simple task. However ...",
"I officially welcome you to the explorer society. From now on you can ask for missions to improve your rank."
}, npc, creature)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Go to Mortimer, ask to join, then for a mission and delivery the pickaxe.
It might help to give you a lot of pickaxe to test with:

/i 4845, 5

Test Configuration:

  • Server Version: 1.4.0
  • Client: 12.86
  • Operating System: Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr merged commit 829dc8a into opentibiabr:main Sep 1, 2022
@lucastsantos lucastsantos deleted the fix-mortimer-dialogue-loop branch September 2, 2022 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants