Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Feature]: Please provide Divider component #354

Closed
kagol opened this issue Aug 1, 2023 · 3 comments
Closed

✨ [Feature]: Please provide Divider component #354

kagol opened this issue Aug 1, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@kagol
Copy link
Member

kagol commented Aug 1, 2023 •
edited

What problem does this feature solve

The divider is a common component. It is expected to provide a divider component similar to the divider component in elementUI.
https://element.eleme.cn/#/en-US/component/divider

What does the proposed API look like

For details, see the divider component in elementUI.
https://element.eleme.cn/#/zh-CN/component/divider

What problem does this feature solve

分隔线是一个很常用的组件，希望提供一个类似elementUI里的divider组件
https://element.eleme.cn/#/zh-CN/component/divider

What does the proposed API look like

可以参考elementUI里的divider组件
https://element.eleme.cn/#/zh-CN/component/divider
@kagol kagol added the enhancement New feature or request label Aug 1, 2023
@kagol kagol changed the title ✨ [Feature]: 希望提供Divider分隔线组件 ✨ [Feature]: Please provide Divider component Aug 2, 2023
@vaebe
Copy link
Contributor

vaebe commented Sep 5, 2023

I can, within two weeks at the latest.

vaebe added a commit to vaebe/tiny-vue that referenced this issue Sep 8, 2023
@vaebe
feature(divider): 增加 Divider 组件 (opentiny#354 close)
ad41e47
@kagol
Copy link
Member Author

kagol commented Sep 8, 2023

I can, within two weeks at the latest.

Welcome~

kagol pushed a commit that referenced this issue Sep 13, 2023
@vaebe
feature(divider): 增加 Divider 组件 (#354 close) (#471)
7d6120e 
* feature(divider): 增加 Divider 组件 (#354 close)

* fix: 移除 lock 文件的提交

* fix: 还原移除的 pnpm-lock.yaml 文件

* fix: 使用 dev 覆盖本地 pnpm-lock.yaml.lock 文件
@kagol
Copy link
Member Author

kagol commented Oct 11, 2023

Finished by @vaebe on #471

@kagol kagol closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kagol @vaebe