fix(steps): resolve text overflow no tooltip #1629
Conversation
WalkthroughThe recent updates focus on enhancing the user experience in the step components across multiple files. Key changes include renaming steps for clarity, updating statuses, improving label styling with flexbox and text truncation, and integrating tooltips for better information display. Additionally, a new custom property for label margins has been introduced to ensure consistent spacing. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- examples/sites/demos/pc/app/steps/advanced-steps-composition-api.vue (1 hunks)
- examples/sites/demos/pc/app/steps/advanced-steps.vue (1 hunks)
- packages/theme/src/steps/index.less (3 hunks)
- packages/theme/src/steps/vars.less (1 hunks)
- packages/vue/src/steps/src/pc/pc-standard.vue (2 hunks)
Files skipped from review due to trivial changes (4)
- examples/sites/demos/pc/app/steps/advanced-steps-composition-api.vue
- examples/sites/demos/pc/app/steps/advanced-steps.vue
- packages/theme/src/steps/index.less
- packages/theme/src/steps/vars.less
Additional comments not posted (2)
packages/vue/src/steps/src/pc/pc-standard.vue (2)
15-22: The integration oftiny-tooltipfor handling text overflow is well implemented.
36-36: The import ofToolTipis correctly added to support the new tooltip functionality.
| import { iconRefres, iconYes } from '@opentiny/vue-icon' | ||
|
|
||
| export default defineComponent({ | ||
| emits: ['click'], | ||
| components: { | ||
| TinyTooltip: ToolTip, |
There was a problem hiding this comment.
Correct the registration of IconRefres and IconYes components.
- IconRefres: iconRefres(),
- IconYes: iconYes()
+ IconRefres: iconRefres,
+ IconYes: iconYesThis change ensures that the components are correctly registered without invoking them as functions.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| TinyTooltip: ToolTip, | |
| TinyTooltip: ToolTip, | |
| IconRefres: iconRefres, | |
| IconYes: iconYes |
| // padding: 0; | ||
| // right: 0; | ||
| // top: 50%; | ||
| // transform: translateY(-50%); |
There was a problem hiding this comment.
| // padding: 0; | |
| // right: 0; | |
| // top: 50%; | |
| // transform: translateY(-50%); |
这一段也许删掉会更好
| display: flex; | ||
| position: absolute; | ||
| // position: absolute; |
There was a problem hiding this comment.
| // position: absolute; |
这一段也许删掉会更好
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Style
Refactor
Chores