Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Global Schema Cache not working in provider acceptance tests #1054

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

RLRabinowitz
Copy link
Collaborator

@RLRabinowitz RLRabinowitz commented Dec 26, 2023

When running provider acceptance tests with the OpenTofu binary, the Global Schema Cache is never used. This causes the acceptance tests to take longer than they should

The reason for that is that unmanaged plugins don't have the Addr attribute, so the Global Schema Cache code never attempts to store or fetch the schema from cache

Resolves #1044

Target Release

1.6.1

…e would work

Signed-off-by: RLRabinowitz <rlrabinowitz2@gmail.com>
@RLRabinowitz RLRabinowitz self-assigned this Dec 26, 2023
@RLRabinowitz RLRabinowitz requested a review from a team as a code owner December 26, 2023 18:14
Copy link

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

Signed-off-by: RLRabinowitz <rlrabinowitz2@gmail.com>
Copy link
Collaborator

@cube2222 cube2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RLRabinowitz RLRabinowitz merged commit fcd241c into main Jan 15, 2024
9 checks passed
@RLRabinowitz RLRabinowitz deleted the unmanaged_plugins_addr branch January 15, 2024 13:18
RLRabinowitz added a commit that referenced this pull request Jan 15, 2024
Signed-off-by: RLRabinowitz <rlrabinowitz2@gmail.com>
cube2222 pushed a commit that referenced this pull request Jan 17, 2024
Signed-off-by: RLRabinowitz <rlrabinowitz2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider acceptance test are slow, not using the Provider Schema cache
3 participants